HBASE-23996 add metric for the split wal procedure

Author: Umeshkumar9414

hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/master/MetricsMasterSource.java

@@ -92,6 +92,7 @@ public interface MetricsMasterSource extends BaseSource {
   String OFFLINE_REGION_COUNT_DESC = "Number of Offline Regions";
 
   String SERVER_CRASH_METRIC_PREFIX = "serverCrash";
+  String SPLIT_WAL_METRIC_PREFIX = "splitWAL";
   String OLD_WAL_DIR_SIZE_DESC = "size of old WALs directory in bytes";
 
   /**
@@ -114,4 +115,7 @@ public interface MetricsMasterSource extends BaseSource {
 
   /** Returns {@link OperationMetrics} containing common metrics for server crash operation */
   OperationMetrics getServerCrashMetrics();
+
+  /** Returns {@link OperationMetrics} containing common metrics for split WAL operation */
+  OperationMetrics getSplitWALMetrics();
 }

hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/master/MetricsMasterSourceImpl.java

@@ -39,6 +39,7 @@ public class MetricsMasterSourceImpl extends BaseSourceImpl implements MetricsMa
   private MutableFastCounter clusterWriteRequestsCounter;
 
   private OperationMetrics serverCrashMetrics;
+  private OperationMetrics splitWALMetrics;
 
   public MetricsMasterSourceImpl(MetricsMasterWrapper masterWrapper) {
     this(METRICS_NAME, METRICS_DESCRIPTION, METRICS_CONTEXT, METRICS_JMX_CONTEXT, masterWrapper);
@@ -64,6 +65,7 @@ public void init() {
      * BaseSourceImpl#registry} to register the new metrics.
      */
     serverCrashMetrics = new OperationMetrics(registry, SERVER_CRASH_METRIC_PREFIX);
+    splitWALMetrics = new OperationMetrics(registry, SPLIT_WAL_METRIC_PREFIX);
   }
 
   @Override
@@ -144,4 +146,9 @@ public void getMetrics(MetricsCollector metricsCollector, boolean all) {
   public OperationMetrics getServerCrashMetrics() {
     return serverCrashMetrics;
   }
+
+  @Override
+  public OperationMetrics getSplitWALMetrics() {
+    return splitWALMetrics;
+  }
 }

hbase-server/src/main/java/org/apache/hadoop/hbase/master/MetricsMaster.java

@@ -43,6 +43,7 @@ public class MetricsMaster {
   private MetricsMasterQuotaSource masterQuotaSource;
 
   private ProcedureMetrics serverCrashProcMetrics;
+  private ProcedureMetrics splitWALProcMetrics;
 
   public MetricsMaster(MetricsMasterWrapper masterWrapper) {
     masterSource = CompatibilitySingletonFactory.getInstance(MetricsMasterSourceFactory.class)
@@ -53,6 +54,7 @@ public MetricsMaster(MetricsMasterWrapper masterWrapper) {
       .getInstance(MetricsMasterQuotaSourceFactory.class).create(masterWrapper);
 
     serverCrashProcMetrics = convertToProcedureMetrics(masterSource.getServerCrashMetrics());
+    splitWALProcMetrics = convertToProcedureMetrics(masterSource.getSplitWALMetrics());
   }
 
   // for unit-test usage
@@ -130,11 +132,16 @@ public void incrementQuotaObserverTime(final long executionTime) {
     masterQuotaSource.incrementSpaceQuotaObserverChoreTime(executionTime);
   }
 
-  /** Returns Set of metrics for assign procedure */
+  /** Returns Set of metrics for server crash procedure */
   public ProcedureMetrics getServerCrashProcMetrics() {
     return serverCrashProcMetrics;
   }
 
+  /** Returns Set of metrics for split WAL procedure */
+  public ProcedureMetrics getSplitWALProcMetrics() {
+    return splitWALProcMetrics;
+  }
+
   /**
    * This is utility function that converts {@link OperationMetrics} to {@link ProcedureMetrics}.
    * NOTE: Procedure framework in hbase-procedure module accesses metrics common to most procedures

hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/SplitWALProcedure.java

@@ -21,6 +21,7 @@
 import org.apache.hadoop.fs.Path;
 import org.apache.hadoop.hbase.ServerName;
 import org.apache.hadoop.hbase.master.SplitWALManager;
+import org.apache.hadoop.hbase.procedure2.ProcedureMetrics;
 import org.apache.hadoop.hbase.procedure2.ProcedureStateSerializer;
 import org.apache.hadoop.hbase.procedure2.ProcedureSuspendedException;
 import org.apache.hadoop.hbase.procedure2.ProcedureUtil;
@@ -193,6 +194,11 @@ protected void afterReplay(MasterProcedureEnv env) {
     }
   }
 
+  @Override
+  protected ProcedureMetrics getProcedureMetrics(MasterProcedureEnv env) {
+    return env.getMasterServices().getMasterMetrics().getSplitWALProcMetrics();
+  }
+
   @Override
   protected void toStringClassDetails(StringBuilder builder) {
     builder.append(getProcName());