Skip to content

Commit bf73a3d

Browse files
HBASE-23996 deprecate ZK-coordinated WAL split classes and metrics
Mark the legacy ZooKeeper-coordinated WAL split coordination classes (ZKSplitLogManagerCoordination, ZkSplitLogWorkerCoordination) and the associated MetricsMasterFileSystem source as deprecated, since the procedure-based distributed WAL splitter (SplitWALManager) is the default and these are only reachable under the legacy hbase.split.writer.coordinated.by.zk path. Co-authored-by: Claude <noreply@anthropic.com>
1 parent 43afec1 commit bf73a3d

5 files changed

Lines changed: 29 additions & 3 deletions

File tree

hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/master/MetricsMasterFileSystemSource.java

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,13 @@
2121
import org.apache.hadoop.hbase.metrics.BaseSource;
2222
import org.apache.yetus.audience.InterfaceAudience;
2323

24+
/**
25+
* @deprecated since 2.4.0 and in 3.0.0, to be removed in 4.0.0, replaced by procedure-based
26+
* distributed WAL splitter; see SplitWALManager. These metrics ({@code hlogSplitTime},
27+
* {@code hlogSplitSize}, {@code metaHlogSplitTime}, {@code metaHlogSplitSize}) are only
28+
* emitted by the deprecated ZK-coordinated WAL split path.
29+
*/
30+
@Deprecated
2431
@InterfaceAudience.Private
2532
public interface MetricsMasterFileSystemSource extends BaseSource {
2633

hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/master/MetricsMasterFilesystemSourceImpl.java

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,13 @@
2121
import org.apache.hadoop.metrics2.MetricHistogram;
2222
import org.apache.yetus.audience.InterfaceAudience;
2323

24+
/**
25+
* @deprecated since 2.4.0 and in 3.0.0, to be removed in 4.0.0, replaced by procedure-based
26+
* distributed WAL splitter; see SplitWALManager. Implementation of the deprecated
27+
* {@link MetricsMasterFileSystemSource}, whose metrics are only emitted by the
28+
* ZK-coordinated WAL split path.
29+
*/
30+
@Deprecated
2431
@InterfaceAudience.Private
2532
public class MetricsMasterFilesystemSourceImpl extends BaseSourceImpl
2633
implements MetricsMasterFileSystemSource {

hbase-server/src/main/java/org/apache/hadoop/hbase/coordination/ZKSplitLogManagerCoordination.java

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,8 +58,11 @@
5858
import org.slf4j.LoggerFactory;
5959

6060
/**
61-
* ZooKeeper based implementation of {@link SplitLogManagerCoordination}
61+
* ZooKeeper based implementation of {@link SplitLogManagerCoordination}.
62+
* @deprecated since 2.4.0 and in 3.0.0, to be removed in 4.0.0, replaced by procedure-based
63+
* distributed WAL splitter; see SplitWALManager.
6264
*/
65+
@Deprecated
6366
@InterfaceAudience.Private
6467
public class ZKSplitLogManagerCoordination extends ZKListener
6568
implements SplitLogManagerCoordination {

hbase-server/src/main/java/org/apache/hadoop/hbase/coordination/ZkSplitLogWorkerCoordination.java

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -57,9 +57,11 @@
5757
import org.slf4j.LoggerFactory;
5858

5959
/**
60-
* ZooKeeper based implementation of {@link SplitLogWorkerCoordination} It listen for changes in
61-
* ZooKeeper and
60+
* ZooKeeper based implementation of {@link SplitLogWorkerCoordination}.
61+
* @deprecated since 2.4.0 and in 3.0.0, to be removed in 4.0.0, replaced by procedure-based
62+
* distributed WAL splitter; see SplitWALManager.
6263
*/
64+
@Deprecated
6365
@InterfaceAudience.Private
6466
public class ZkSplitLogWorkerCoordination extends ZKListener implements SplitLogWorkerCoordination {
6567

hbase-server/src/main/java/org/apache/hadoop/hbase/master/MetricsMasterFileSystem.java

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,13 @@
2020
import org.apache.hadoop.hbase.CompatibilitySingletonFactory;
2121
import org.apache.yetus.audience.InterfaceAudience;
2222

23+
/**
24+
* @deprecated since 2.4.0 and in 3.0.0, to be removed in 4.0.0, replaced by procedure-based
25+
* distributed WAL splitter; see SplitWALManager. These metrics ({@code hlogSplitTime},
26+
* {@code hlogSplitSize}, {@code metaHlogSplitTime}, {@code metaHlogSplitSize}) are only
27+
* emitted by the deprecated ZK-coordinated WAL split path.
28+
*/
29+
@Deprecated
2330
@InterfaceAudience.Private
2431
public class MetricsMasterFileSystem {
2532

0 commit comments

Comments
 (0)