Skip to content

Commit 14687f8

Browse files
committed
Record drilldown metadata in evidence drafts
1 parent 86a3f44 commit 14687f8

2 files changed

Lines changed: 9 additions & 0 deletions

File tree

web-next/lib/signal-dashboards.test.ts

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2408,6 +2408,9 @@ describe('signal dashboards API client', () => {
24082408
meta: 'ERROR',
24092409
traceId: 'trace-1',
24102410
spanId: 'span-log',
2411+
operationName: 'POST /checkout',
2412+
resourceFilter: 'service.version=1.2.3',
2413+
attributeFilter: 'region:us',
24112414
relatedSignal: 'traces'
24122415
},
24132416
route: '/log/manage?view=table&traceId=trace-1&spanId=span-log&serviceName=checkout&start=1000&end=3000',
@@ -2431,6 +2434,9 @@ describe('signal dashboards API client', () => {
24312434
evidenceValue: 'checkout timeout',
24322435
traceId: 'trace-1',
24332436
spanId: 'span-log',
2437+
operationName: 'POST /checkout',
2438+
resourceFilter: 'service.version=1.2.3',
2439+
attributeFilter: 'region:us',
24342440
relatedSignal: 'traces'
24352441
}));
24362442
expect(createSignalDashboardPanelDraftFromRuntimeEvidence({

web-next/lib/signal-dashboards.ts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1254,6 +1254,9 @@ export function createSignalDashboardPanelDraftFromRuntimeEvidence(input: {
12541254
evidenceValue: input.row.value,
12551255
...(input.row.traceId ? { traceId: input.row.traceId } : {}),
12561256
...(input.row.spanId ? { spanId: input.row.spanId } : {}),
1257+
...(input.row.operationName ? { operationName: input.row.operationName } : {}),
1258+
...(input.row.resourceFilter ? { resourceFilter: input.row.resourceFilter } : {}),
1259+
...(input.row.attributeFilter ? { attributeFilter: input.row.attributeFilter } : {}),
12571260
...(input.row.relatedSignal ? { relatedSignal: input.row.relatedSignal } : {})
12581261
}
12591262
});

0 commit comments

Comments
 (0)