Replies: 3 comments
-
|
Hi I think there is a misunderstanding here. Although the titles of these PRs are similar, if you look at the content, they are all meaningful i18n function supplement PRs. @Calvin979 is a committer member of our community and has also submitted many other feature PRs https://github.com/apache/hertzbeat/commits?author=Calvin979&after=c21a2952a56ddf8225174009f4972bea8130c290+69 . |
Beta Was this translation helpful? Give feedback.
-
|
Hi, @hgroo Thanks for your suggestions. I will use a more meaningful commit comment for those PR The reason my spliting commits is that I am doing Japanese i18n function like what we did before |
Beta Was this translation helpful? Give feedback.
-
|
Hi, @hgroo thank you for your question. Considering the direction of the community, I think what you said is fine. However, I have a better suggestion. I see that you have not paid attention to our project. I recommend that you fork and star our project, then make long-term, healthy contributions. Once you become a PMC for the hertzbeat project, you can choose to review or reject what you consider to be @Calvin979's "unhealthy" PR 💪 |
Beta Was this translation helpful? Give feedback.
Uh oh!
There was an error while loading. Please reload this page.
-
@tomsun28
I have seen many PRs with similar functions. Although ASF does not require the rule of [prohibiting split commits], according to the official culture and most projects, the following principles are emphasized:
1. Do not accept commits
2. Avoid meaningless submissions
3. Do not accept deliberate splitting
4. Or deliberately split commits to increase the number of contributions
In most projects, the PMC has the right to refuse to merge, or directly reject the PR during review, and even affect the credibility and evaluation of the contributor or committer.
I think commits should have meaning. Splitting commits for resume, activity or other purposes is unacceptable, and PMCs have an obligation to mark and remind them, because long-term health of contributions is far more important than quantity.

Beta Was this translation helpful? Give feedback.
All reactions