Skip to content

Commit 000cd22

Browse files
committed
Merge r1921067 from trunk:
* Take care for the case where nkey is NULL PR: 69358 Reported by: <zhora.budyukin111 gmail.com> Submitted by: rpluem Reviewed by: jailletc36, rjung, jorton git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/2.4.x@1923247 13f79535-47bb-0310-9956-ffa450edef68
1 parent 516588e commit 000cd22

File tree

2 files changed

+8
-3
lines changed

2 files changed

+8
-3
lines changed

CHANGES

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,9 @@
11
-*- coding: utf-8 -*-
22
Changes with Apache 2.4.63
33

4+
*) mod_cache_socache: Fix possible crash on error path. PR 69358.
5+
[Ruediger Pluem]
6+
47
*) mod_md: update to version 2.4.31
58
- Improved error reporting when waiting for ACME server to verify domains
69
or finalizing the order fails, e.g. times out.

modules/cache/mod_cache_socache.c

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -700,9 +700,11 @@ static int open_entity(cache_handle_t *h, request_rec *r, const char *key)
700700
return DECLINED;
701701
}
702702
}
703-
conf->provider->socache_provider->remove(
704-
conf->provider->socache_instance, r->server,
705-
(unsigned char *) nkey, strlen(nkey), r->pool);
703+
if (nkey) {
704+
conf->provider->socache_provider->remove(
705+
conf->provider->socache_instance, r->server,
706+
(unsigned char *) nkey, strlen(nkey), r->pool);
707+
}
706708
if (socache_mutex) {
707709
apr_status_t status = apr_global_mutex_unlock(socache_mutex);
708710
if (status != APR_SUCCESS) {

0 commit comments

Comments
 (0)