Skip to content

Commit 0acf216

Browse files
committed
*) mod_http2: fix test_h2_200_17+18 for newer curl versions. Just add log
output and add to test checks. No functional change. Merges r1923187 from trunk. git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/2.4.x@1923238 13f79535-47bb-0310-9956-ffa450edef68
1 parent bf53e15 commit 0acf216

File tree

3 files changed

+8
-8
lines changed

3 files changed

+8
-8
lines changed

STATUS

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -157,10 +157,6 @@ RELEASE SHOWSTOPPERS:
157157
PATCHES ACCEPTED TO BACKPORT FROM TRUNK:
158158
[ start all new proposals below, under PATCHES PROPOSED. ]
159159

160-
*) mod_http2: fix test_h2_200_17+18 for newer curl versions. Just add log
161-
output and add to test checks. No functional change.
162-
2.4.x patch: svn merge -c 1923187 ^/httpd/httpd/trunk .
163-
+1: icing, jim, rjung
164160

165161
PATCHES PROPOSED TO BACKPORT FROM TRUNK:
166162
[ New proposals should be added at the end of the list ]

modules/http2/h2_session.c

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -363,9 +363,11 @@ static int on_frame_recv_cb(nghttp2_session *ng2s,
363363
else {
364364
ap_log_cerror(APLOG_MARK, APLOG_DEBUG, 0, session->c1,
365365
H2_SSSN_LOG(APLOGNO(03066), session,
366-
"recv FRAME[%s], frames=%ld/%ld (r/s)"),
366+
"recv FRAME[%s], frames=%ld/%ld (r/s), "
367+
"remote.emitted=%d"),
367368
buffer, (long)session->frames_received,
368-
(long)session->frames_sent);
369+
(long)session->frames_sent,
370+
(int)session->remote.emitted_count);
369371
}
370372
}
371373

test/modules/http2/test_200_header_invalid.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -243,7 +243,8 @@ def test_h2_200_17(self, env):
243243
conf.add_vhost_cgi()
244244
conf.install()
245245
assert env.apache_restart() == 0
246-
re_emitted = re.compile(r'.* AH03401: .* shutdown, remote.emitted=1')
246+
re_emitted = re.compile(r'.* (AH03401: .* shutdown,|'
247+
r'AH03066: .* FRAME\[GOAWAY.*) remote.emitted=1')
247248
url = env.mkurl("https", "cgi", "/")
248249
opt = []
249250
for i in range(10):
@@ -263,7 +264,8 @@ def test_h2_200_18(self, env):
263264
conf.add_vhost_cgi()
264265
conf.install()
265266
assert env.apache_restart() == 0
266-
re_emitted = re.compile(r'.* AH03401: .* shutdown, remote.emitted=1')
267+
re_emitted = re.compile(r'.* (AH03401: .* shutdown,|'
268+
r'AH03066: .* FRAME\[GOAWAY.*) remote.emitted=1')
267269
url = env.mkurl("https", "cgi", "/")
268270
opt = []
269271
for i in range(100):

0 commit comments

Comments
 (0)