Skip to content

Commit 4164c48

Browse files
committed
mod_asis: Fix the log level of the message AH01236
Change the log level from ERROR to DEBUG. The message \"mod_asis: ap_pass_brigade failed for file ...\" was logged with the level ERROR. This log level is inappropriate here, because a client can trigger this log message by aborting the request. Most other modules don't log at all or use the log level DEBUG when ap_pass_brigade() fails. Submitted by: Michael Kaufmann <mail michael-kaufmann.ch> Github: closes #527 Add a change entry to give credits to the author. Merges r1924954, r1926191 trunk Submitted by: jorton, jailletc36 Reviewed by: jailletc36, rpluem, ylavic git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/2.4.x@1926328 13f79535-47bb-0310-9956-ffa450edef68
1 parent c615d09 commit 4164c48

File tree

2 files changed

+4
-1
lines changed

2 files changed

+4
-1
lines changed

CHANGES

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,9 @@
11
-*- coding: utf-8 -*-
22
Changes with Apache 2.4.64
33

4+
*) mod_asis: Fix the log level of the message AH01236.
5+
Github #527 [Michael Kaufmann <mail michael-kaufmann.ch>]
6+
47
*) mod_session_dbd: ensure format used with SessionDBDCookieName and
58
SessionDBDCookieName2 are correct.
69
Github #503 [Thomas Meyer <thomas m3y3r.de>]

modules/generators/mod_asis.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -99,7 +99,7 @@ static int asis_handler(request_rec *r)
9999
APR_BRIGADE_INSERT_TAIL(bb, b);
100100
rv = ap_pass_brigade(r->output_filters, bb);
101101
if (rv != APR_SUCCESS) {
102-
ap_log_rerror(APLOG_MARK, APLOG_ERR, rv, r, APLOGNO(01236)
102+
ap_log_rerror(APLOG_MARK, APLOG_DEBUG, rv, r, APLOGNO(01236)
103103
"mod_asis: ap_pass_brigade failed for file %s", r->filename);
104104
return AP_FILTER_ERROR;
105105
}

0 commit comments

Comments
 (0)