Skip to content

Commit 8486d22

Browse files
committed
Merge r1917017, r1923218 from trunk:
* server/core.c (set_override): Catch errors returned by set_allow_opts() for a parsing fail in an Options= argument. Submitted by: Zhou Qingyang <zhou1615 umn.edu> Github: closes #310 Add a Changes entry related to r1917017 While at it, fix a small style issue (tab vs spaces) Submitted by: jorton, jailletc36 Reviewed by: rjung (reduce code drift), jorton, jailletc36 git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/2.4.x@1923804 13f79535-47bb-0310-9956-ffa450edef68
1 parent ad2371e commit 8486d22

File tree

2 files changed

+7
-2
lines changed

2 files changed

+7
-2
lines changed

changes-entries/github 310.txt

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
*) core: Report invalid Options= argument when parsing AllowOverride
2+
directives.
3+
Github #310 [Zhou Qingyang <zhou1615 umn.edu>]

server/core.c

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1838,8 +1838,10 @@ static const char *set_override(cmd_parms *cmd, void *d_, const char *l)
18381838
}
18391839
else if (!ap_cstr_casecmp(k, "Options")) {
18401840
d->override |= OR_OPTIONS;
1841-
if (v)
1842-
set_allow_opts(cmd, &(d->override_opts), v);
1841+
if (v) {
1842+
if ((err = set_allow_opts(cmd, &(d->override_opts), v)) != NULL)
1843+
return err;
1844+
}
18431845
else
18441846
d->override_opts = OPT_ALL;
18451847
}

0 commit comments

Comments
 (0)