Utilities using jcommander for boolean argument can be misleading #13845
xushiyan
started this conversation in
General Discussions
Replies: 2 comments
-
+1, I got a lot of feedback because of these confusions. A explicit param |
Beta Was this translation helpful? Give feedback.
0 replies
-
Can we list out all such boolean flags? are they all fixable without causing any side-effects 'silently' i.e changing behavior for the Hudi streamer run .. This discussion will be more actionable with that analysis |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
When people use Hudi utilities, many of them are not aware of
--a-boolean-flag
being present meanstrue
, and by following other args' pattern, they tend to set--a-boolean-flag true
which resulted inTo improve this experience, we should allow both ways to set a boolean arg. People should be able to
To go further, any boolean arg used by utilities should be changed to default false. This may lead to breaking some usage, but it's a necessary step to align the expectations.
Beta Was this translation helpful? Give feedback.
All reactions