Skip to content

Commit a4e6d66

Browse files
authored
Merge pull request #1 from sungwy/sungwy-patch-1
clean up
2 parents a79ba1e + e4197e5 commit a4e6d66

File tree

3 files changed

+61
-13
lines changed

3 files changed

+61
-13
lines changed

.github/workflows/release_python.yml

+32-13
Original file line numberDiff line numberDiff line change
@@ -82,12 +82,40 @@ jobs:
8282
name: wheels
8383
path: bindings/python/dist
8484

85-
publish:
86-
name: Publish Python 🐍 distribution 📦
85+
pypi-publish:
86+
name: Publish Python 🐍 distribution 📦 to Pypi
8787
needs: [ sdist, linux ]
8888
runs-on: ubuntu-latest
89-
# Only publish if it's a tag
90-
if: "startsWith(github.ref, 'refs/tags/')"
89+
# Only publish to PyPi if the tag is not a pre-release
90+
if: ${{ startsWith(github.ref, 'refs/tags/') && !contains(github.ref, '-') }}
91+
92+
environment:
93+
name: pypi
94+
url: https://pypi.org/p/pyiceberg_core
95+
96+
permissions:
97+
id-token: write # IMPORTANT: mandatory for trusted publishing
98+
99+
steps:
100+
- name: Download all the dists
101+
uses: actions/download-artifact@v3
102+
with:
103+
name: wheels
104+
path: bindings/python/dist
105+
- name: Publish to PyPI
106+
uses: pypa/gh-action-pypi-publish@release/v1
107+
108+
with:
109+
skip-existing: true
110+
packages-dir: bindings/python/dist
111+
112+
testpypi-publish:
113+
name: Publish Python 🐍 distribution 📦 to TestPypi
114+
needs: [ sdist, linux ]
115+
runs-on: ubuntu-latest
116+
# Only publish to TestPyPi if the tag is a pre-release
117+
if: ${{ startsWith(github.ref, 'refs/tags/') && contains(github.ref, '-')}}
118+
91119
environment:
92120
name: testpypi
93121
url: https://test.pypi.org/p/pyiceberg_core
@@ -102,17 +130,8 @@ jobs:
102130
name: wheels
103131
path: bindings/python/dist
104132
- name: Publish to TestPyPI
105-
# Only publish to TestPyPi if the tag is a pre-release
106-
if: "contains(github.ref, '-')"
107133
uses: pypa/gh-action-pypi-publish@release/v1
108134
with:
109135
repository-url: https://test.pypi.org/legacy/
110136
skip-existing: true
111137
packages-dir: bindings/python/dist
112-
- name: Publish to PyPI
113-
uses: pypa/gh-action-pypi-publish@release/v1
114-
# Only publish to PyPi if the tag is not a pre-release
115-
if: "!contains(github.ref, '-')"
116-
with:
117-
skip-existing: true
118-
packages-dir: bindings/python/dist
+28
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,28 @@
1+
<!--
2+
~ Licensed to the Apache Software Foundation (ASF) under one
3+
~ or more contributor license agreements. See the NOTICE file
4+
~ distributed with this work for additional information
5+
~ regarding copyright ownership. The ASF licenses this file
6+
~ to you under the Apache License, Version 2.0 (the
7+
~ "License"); you may not use this file except in compliance
8+
~ with the License. You may obtain a copy of the License at
9+
~
10+
~ http://www.apache.org/licenses/LICENSE-2.0
11+
~
12+
~ Unless required by applicable law or agreed to in writing,
13+
~ software distributed under the License is distributed on an
14+
~ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
15+
~ KIND, either express or implied. See the License for the
16+
~ specific language governing permissions and limitations
17+
~ under the License.
18+
-->
19+
20+
# Pyiceberg Core
21+
22+
This project is used to build an iceberg-rust powered core for pyiceberg, and intended for use only by pyiceberg.
23+
24+
Install via PyPI:
25+
26+
```
27+
pip install pyiceberg_core
28+
```

bindings/python/pyproject.toml

+1
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@ build-backend = "maturin"
2222
[project]
2323
name = "pyiceberg_core"
2424
version = "0.0.1"
25+
readme = "project-description.md"
2526
classifiers = [
2627
"Development Status :: 4 - Beta",
2728
"Intended Audience :: Developers",

0 commit comments

Comments
 (0)