Spark-3.5: Add unit tests for ColumnarBatchUtil #12275
Open
+161
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anuragmantri
commented
Feb 14, 2025
| @Test | ||
| public void testBuildRowIdMapping() { | ||
| when(deleteFilter.hasPosDeletes()).thenReturn(true); | ||
| PositionDeleteIndex deletedRowPos = mock(PositionDeleteIndex.class); |
There was a problem hiding this comment.
I'm not sure how we can mock the equality deletes as they apply to entire rows. I appreciate any suggestions.
anuragmantri
commented
Feb 14, 2025
anuragmantri
force-pushed
the
columnarbatchutil-tests
branch
from
b514d91 to
6eec97d
Compare
anuragmantri
force-pushed
the
columnarbatchutil-tests
branch
from
6faf072 to
6794c2e
Compare
|
This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the [email protected] list. Thank you for your contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #12054
ColumnarBatchUtilclass was added as part of delete logic refactor #11933. This PR adds unit tests for this class and minor refactor of test packages to match with the class.