Move docker-specific tests to integrationTest configuration

[nastra]

Feature Request / Improvement

Currently, docker-specific tests run under the test configuration and we'd like to move those to integrationTest. Examples of such tests use the @Testcontainers annotation

Query engine

None

Willingness to contribute

• I can contribute this improvement/feature independently
• I would be willing to contribute this improvement/feature with guidance from the Iceberg community
• I cannot contribute this improvement/feature at this time

[anuragmantri]

I have seen similar issues on Azure tests on some of my environments. I will submit a PR to move these tests to integration tests source sets. Thanks for creating the issue.

[kevinjqliu]

BTW, i ran ./gradlew test --continue without the docker daemon and these are the 9 tests that failed and requires docker.

> Task :iceberg-azure:test
ADLSFileIOTest > initializationError FAILED
ADLSInputStreamTest > initializationError FAILED
ADLSOutputStreamTest > initializationError FAILED

> Task :iceberg-aws:test
TestFlakyS3InputStream > initializationError FAILED
TestMinioUtil > initializationError FAILED
TestS3FileIO > initializationError FAILED
TestS3InputStream > initializationError FAILED
TestS3OutputStream > initializationError FAILED
TestS3RestSigner > initializationError FAILED

[kevinjqliu]

As part of testing 1.8.1rc1, i also found these 3 tests relying on docker

> Task :iceberg-kafka-connect:iceberg-kafka-connect-runtime:integrationTest FAILED
IntegrationDynamicTableTest > initializationError FAILED
IntegrationMultiTableTest > initializationError FAILED
IntegrationTest > initializationError FAILED

[kevinjqliu]

hey @nastra I dont think we can close the issue just yet. we'd want to be able to run ./gradlew build without any docker daemon

[anuragmantri]

Sorry, it was my mistake, I think I marked my PR as fixes this issue. When @nastra merged, it would have automatically closed this issue. I removed the comment from the description. I think we need to reopen this to track the actual issues with docker tests and fix them.

[kevinjqliu]

reopened!

[kevinjqliu]

Out of the 3 failed test suites, #12274 only addressed iceberg-azure, right?

> Task :iceberg-azure:test
> Task :iceberg-aws:test
> Task :iceberg-kafka-connect:iceberg-kafka-connect-runtime:integrationTest

[anuragmantri]

That's correct. We cannot move AWS tests since we don't run AWS integration tests at all. I haven't looked at the Kafka tests though

[kevinjqliu]

We cannot move AWS tests since we don't run AWS integration tests at all.

what does "we dont run AWS integration tests at all" mean?

For context, this issue came out of verifying a new release, https://iceberg.apache.org/how-to-release/#verifying-build-and-test. Running ./gradlew build will run tests including the ones above which require docker.

I thought the idea was to move these to integrationTest so that ./gradlew build only runs unit tests. And we can add additional integration tests run command.

[anuragmantri]

what does "we dont run AWS integration tests at all" mean?

AWS integration tests require some keys as ENV vars to successfully run. So today our CI does not run any AWS integration tests. If we move the current docker tests to integration, they will be missed. An option I proposed is to create a new suite called dockerIntegrationTests for AWS so we can run these. See here and here. I'm open to better ideas though.

I thought the idea was to move these to integrationTest so that ./gradlew build only runs unit tests. And we can add additional integration tests run command.

Yes, this is indeed the idea. We already have gradlew integrationTest some modules already have tests that run on gradle check in the CI. It's just the AWS ones don't run today.