Replies: 5 comments 5 replies
-
|
I agree with the sentiment. That said, currently, pre-commit checks exist only for rust, but the CI defines checks for every language. This means that a contributor needs to run these checks manually, which many of them forget to do. I would propose adding these checks to the pre-commit config as well. |
Beta Was this translation helpful? Give feedback.
-
|
I do fully agree that in recent times, due to the obvious reasons, the lifecycle of OSS projects has been unfortunately disrupted, thus, clearer, even stricter guidelines would be helpful. |
Beta Was this translation helpful? Give feedback.
-
|
+1 for the policy, things start to get quite ridiculous with how effortless it became to create an "contribution". |
Beta Was this translation helpful? Give feedback.
-
|
I think this is more than reasonable. As a newbie, I very much like the high effort and positive vibes from all the (core) members. This should not be washed out by energy draining work. So these policies can also protect new joiners who want to make a serious effort. In addition to the things already mentioned in the PR it might be reasonable to make benchmark tests mandatory. |
Beta Was this translation helpful? Give feedback.
-
|
+1 @hubcio thanks for putting this together. we need to publish and enforce these guidelines sooner than later. |
Beta Was this translation helpful? Give feedback.
Uh oh!
There was an error while loading. Please reload this page.
-
We've noticed a patterns lately:
It's burning maintainers time and will.
So i propose tightening up in #2601:
Thoughts?
Beta Was this translation helpful? Give feedback.
All reactions