Skip to content

Commit 19c6ec0

Browse files
kleshklesh
authored
fix: github deployment status active and inactive should be treated as success (#6875)
1 parent 0d7a27e commit 19c6ec0

File tree

3 files changed

+10
-10
lines changed

3 files changed

+10
-10
lines changed

‎backend/plugins/github/e2e/snapshot_tables/cicd_deployment_commits.csv‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,12 @@
11
id,commit_sha,cicd_scope_id,cicd_deployment_id,name,result,status,environment,created_date,started_date,finished_date,duration_sec,ref_name,repo_id,repo_url,prev_success_deployment_commit_id
2-
github:GithubDeployment:1:MDEwOkRlcGxveW1lbnQ0MDcyNjE5N5==,f3f308ffaf23b98d2cf0ea34d7065a690a6560da,github:GithubRepo:1:134018330,github:GithubDeployment:1:MDEwOkRlcGxveW1lbnQ0MDcyNjE5N5==,f3f308ffaf23b98d2cf0ea34d7065a690a6560da,,IN_PROGRESS,github-pages,2017-06-14T23:19:10.000+00:00,2017-06-14T23:19:10.000+00:00,2017-06-14T23:19:10.000+00:00,0,,github:GithubRepo:1:134018330,https://github.com/panjf2000/ants,
32
github:GithubDeployment:1:MDEwOkRlcGxveW1lbnQ0MDE4NjU5N1==,c22c398cec3f6a0e75a806c369dc6cc92addf598,github:GithubRepo:1:134018330,github:GithubDeployment:1:MDEwOkRlcGxveW1lbnQ0MDE4NjU5N1==,c22c398cec3f6a0e75a806c369dc6cc92addf598,SUCCESS,DONE,github-pages,2017-06-09T23:06:33.000+00:00,2017-06-09T23:06:33.000+00:00,2017-06-09T23:06:33.000+00:00,0,,github:GithubRepo:1:134018330,https://github.com/panjf2000/ants,
4-
github:GithubDeployment:1:MDEwOkRlcGxveW1lbnQ0MDgwMzcwN6==,b1e6227e675aae6e62b40803f06be690031cb145,github:GithubRepo:1:134018330,github:GithubDeployment:1:MDEwOkRlcGxveW1lbnQ0MDgwMzcwN6==,b1e6227e675aae6e62b40803f06be690031cb145,,IN_PROGRESS,github-pages,2017-06-15T14:56:14.000+00:00,2017-06-15T14:56:14.000+00:00,2017-06-15T14:56:14.000+00:00,0,,github:GithubRepo:1:134018330,https://github.com/panjf2000/ants,
53
github:GithubDeployment:1:MDEwOkRlcGxveW1lbnQ0MDU0Mzg3N2==,e4a9af594f75c1077f8c0e7ff99b1841f5fcae65,github:GithubRepo:1:134018330,github:GithubDeployment:1:MDEwOkRlcGxveW1lbnQ0MDU0Mzg3N2==,e4a9af594f75c1077f8c0e7ff99b1841f5fcae65,FAILURE,DONE,github-pages,2017-06-13T14:42:26.000+00:00,2017-06-13T14:42:26.000+00:00,2017-06-13T14:42:26.000+00:00,0,,github:GithubRepo:1:134018330,https://github.com/panjf2000/ants,
64
github:GithubDeployment:1:MDEwOkRlcGxveW1lbnQ0MDU2Mjg4M3==,dc204718f0e4596b6c13fe3de7cfdeaf3905a50d,github:GithubRepo:1:134018330,github:GithubDeployment:1:MDEwOkRlcGxveW1lbnQ0MDU2Mjg4M3==,dc204718f0e4596b6c13fe3de7cfdeaf3905a50d,FAILURE,DONE,github-pages,2017-06-13T17:19:09.000+00:00,2017-06-13T17:19:09.000+00:00,2017-06-13T17:19:09.000+00:00,0,,github:GithubRepo:1:134018330,https://github.com/panjf2000/ants,
75
github:GithubDeployment:1:MDEwOkRlcGxveW1lbnQ0MDU5NTY0N4==,e7020c61065fb95b591bd06a3f79bf95d505e0d1,github:GithubRepo:1:134018330,github:GithubDeployment:1:MDEwOkRlcGxveW1lbnQ0MDU5NTY0N4==,e7020c61065fb95b591bd06a3f79bf95d505e0d1,,IN_PROGRESS,github-pages,2017-06-13T23:05:35.000+00:00,2017-06-13T23:05:35.000+00:00,2017-06-13T23:05:35.000+00:00,0,,github:GithubRepo:1:134018330,https://github.com/panjf2000/ants,
6+
github:GithubDeployment:1:MDEwOkRlcGxveW1lbnQ0MDcyNjE5N5==,f3f308ffaf23b98d2cf0ea34d7065a690a6560da,github:GithubRepo:1:134018330,github:GithubDeployment:1:MDEwOkRlcGxveW1lbnQ0MDcyNjE5N5==,f3f308ffaf23b98d2cf0ea34d7065a690a6560da,,IN_PROGRESS,github-pages,2017-06-14T23:19:10.000+00:00,2017-06-14T23:19:10.000+00:00,2017-06-14T23:19:10.000+00:00,0,,github:GithubRepo:1:134018330,https://github.com/panjf2000/ants,
7+
github:GithubDeployment:1:MDEwOkRlcGxveW1lbnQ0MDgwMzcwN6==,b1e6227e675aae6e62b40803f06be690031cb145,github:GithubRepo:1:134018330,github:GithubDeployment:1:MDEwOkRlcGxveW1lbnQ0MDgwMzcwN6==,b1e6227e675aae6e62b40803f06be690031cb145,,IN_PROGRESS,github-pages,2017-06-15T14:56:14.000+00:00,2017-06-15T14:56:14.000+00:00,2017-06-15T14:56:14.000+00:00,0,,github:GithubRepo:1:134018330,https://github.com/panjf2000/ants,
88
github:GithubDeployment:1:MDEwOkRlcGxveW1lbnQ0MjAwMzE5M7==,7bc32d9148e612b54c1909ecf56a62a08cb7b0e7,github:GithubRepo:1:134018330,github:GithubDeployment:1:MDEwOkRlcGxveW1lbnQ0MjAwMzE5M7==,7bc32d9148e612b54c1909ecf56a62a08cb7b0e7,,IN_PROGRESS,github-pages,2017-06-26T18:03:49.000+00:00,2017-06-26T18:03:49.000+00:00,2017-06-26T18:03:49.000+00:00,0,,github:GithubRepo:1:134018330,https://github.com/panjf2000/ants,
99
github:GithubDeployment:1:MDEwOkRlcGxveW1lbnQ0MjM3NTU0M8==,6941c84de27d8a306510af3a03812b26ec421725,github:GithubRepo:1:134018330,github:GithubDeployment:1:MDEwOkRlcGxveW1lbnQ0MjM3NTU0M8==,6941c84de27d8a306510af3a03812b26ec421725,,OTHER,github-pages,2017-06-29T15:13:53.000+00:00,2017-06-29T15:13:53.000+00:00,2017-06-29T15:13:53.000+00:00,0,,github:GithubRepo:1:134018330,https://github.com/panjf2000/ants,
10-
github:GithubDeployment:1:MDEwOkRlcGxveW1lbnQ0MzY0MzQ1N9==,5f0258bc04265e1f46e5eb7f685d91a0a7075031,github:GithubRepo:1:134018330,github:GithubDeployment:1:MDEwOkRlcGxveW1lbnQ0MzY0MzQ1N9==,5f0258bc04265e1f46e5eb7f685d91a0a7075031,,OTHER,github-pages,2017-07-11T13:09:32.000+00:00,2017-07-11T13:09:32.000+00:00,2017-07-11T13:09:32.000+00:00,0,,github:GithubRepo:1:134018330,https://github.com/panjf2000/ants,
11-
github:GithubDeployment:1:MDEwOkRlcGxveW1lbnQ0NTQ3OTQ4O0==,0be0c9ca727d106f85f126cf8beb10a6843af352,github:GithubRepo:1:134018330,github:GithubDeployment:1:MDEwOkRlcGxveW1lbnQ0NTQ3OTQ4O0==,0be0c9ca727d106f85f126cf8beb10a6843af352,,OTHER,github-pages,2017-07-26T19:43:48.000+00:00,2017-07-26T19:43:48.000+00:00,2017-07-26T19:43:48.000+00:00,0,,github:GithubRepo:1:134018330,https://github.com/panjf2000/ants,
10+
github:GithubDeployment:1:MDEwOkRlcGxveW1lbnQ0MzY0MzQ1N9==,5f0258bc04265e1f46e5eb7f685d91a0a7075031,github:GithubRepo:1:134018330,github:GithubDeployment:1:MDEwOkRlcGxveW1lbnQ0MzY0MzQ1N9==,5f0258bc04265e1f46e5eb7f685d91a0a7075031,SUCCESS,DONE,github-pages,2017-07-11T13:09:32.000+00:00,2017-07-11T13:09:32.000+00:00,2017-07-11T13:09:32.000+00:00,0,,github:GithubRepo:1:134018330,https://github.com/panjf2000/ants,
11+
github:GithubDeployment:1:MDEwOkRlcGxveW1lbnQ0NTQ3OTQ4O0==,0be0c9ca727d106f85f126cf8beb10a6843af352,github:GithubRepo:1:134018330,github:GithubDeployment:1:MDEwOkRlcGxveW1lbnQ0NTQ3OTQ4O0==,0be0c9ca727d106f85f126cf8beb10a6843af352,SUCCESS,DONE,github-pages,2017-07-26T19:43:48.000+00:00,2017-07-26T19:43:48.000+00:00,2017-07-26T19:43:48.000+00:00,0,,github:GithubRepo:1:134018330,https://github.com/panjf2000/ants,
1212
github:GithubDeployment:1:MDEwOkRlcGxveW1lbnQ0NTQ4MDI010==,8faba4cb2f03fa56ab6671d58f46d44622f36561,github:GithubRepo:1:134018330,github:GithubDeployment:1:MDEwOkRlcGxveW1lbnQ0NTQ4MDI010==,8faba4cb2f03fa56ab6671d58f46d44622f36561,,OTHER,github-pages,2017-07-26T19:50:31.000+00:00,2017-07-26T19:50:31.000+00:00,2017-07-26T19:50:31.000+00:00,0,,github:GithubRepo:1:134018330,https://github.com/panjf2000/ants,

‎backend/plugins/github/e2e/snapshot_tables/cicd_deployments.csv‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,12 @@
11
id,cicd_scope_id,name,result,status,environment,created_date,started_date,finished_date,duration_sec
2-
github:GithubDeployment:1:MDEwOkRlcGxveW1lbnQ0MDcyNjE5N5==,github:GithubRepo:1:134018330,f3f308ffaf23b98d2cf0ea34d7065a690a6560da,,IN_PROGRESS,github-pages,2017-06-14T23:19:10.000+00:00,2017-06-14T23:19:10.000+00:00,2017-06-14T23:19:10.000+00:00,0
32
github:GithubDeployment:1:MDEwOkRlcGxveW1lbnQ0MDE4NjU5N1==,github:GithubRepo:1:134018330,c22c398cec3f6a0e75a806c369dc6cc92addf598,SUCCESS,DONE,github-pages,2017-06-09T23:06:33.000+00:00,2017-06-09T23:06:33.000+00:00,2017-06-09T23:06:33.000+00:00,0
4-
github:GithubDeployment:1:MDEwOkRlcGxveW1lbnQ0MDgwMzcwN6==,github:GithubRepo:1:134018330,b1e6227e675aae6e62b40803f06be690031cb145,,IN_PROGRESS,github-pages,2017-06-15T14:56:14.000+00:00,2017-06-15T14:56:14.000+00:00,2017-06-15T14:56:14.000+00:00,0
53
github:GithubDeployment:1:MDEwOkRlcGxveW1lbnQ0MDU0Mzg3N2==,github:GithubRepo:1:134018330,e4a9af594f75c1077f8c0e7ff99b1841f5fcae65,FAILURE,DONE,github-pages,2017-06-13T14:42:26.000+00:00,2017-06-13T14:42:26.000+00:00,2017-06-13T14:42:26.000+00:00,0
64
github:GithubDeployment:1:MDEwOkRlcGxveW1lbnQ0MDU2Mjg4M3==,github:GithubRepo:1:134018330,dc204718f0e4596b6c13fe3de7cfdeaf3905a50d,FAILURE,DONE,github-pages,2017-06-13T17:19:09.000+00:00,2017-06-13T17:19:09.000+00:00,2017-06-13T17:19:09.000+00:00,0
75
github:GithubDeployment:1:MDEwOkRlcGxveW1lbnQ0MDU5NTY0N4==,github:GithubRepo:1:134018330,e7020c61065fb95b591bd06a3f79bf95d505e0d1,,IN_PROGRESS,github-pages,2017-06-13T23:05:35.000+00:00,2017-06-13T23:05:35.000+00:00,2017-06-13T23:05:35.000+00:00,0
6+
github:GithubDeployment:1:MDEwOkRlcGxveW1lbnQ0MDcyNjE5N5==,github:GithubRepo:1:134018330,f3f308ffaf23b98d2cf0ea34d7065a690a6560da,,IN_PROGRESS,github-pages,2017-06-14T23:19:10.000+00:00,2017-06-14T23:19:10.000+00:00,2017-06-14T23:19:10.000+00:00,0
7+
github:GithubDeployment:1:MDEwOkRlcGxveW1lbnQ0MDgwMzcwN6==,github:GithubRepo:1:134018330,b1e6227e675aae6e62b40803f06be690031cb145,,IN_PROGRESS,github-pages,2017-06-15T14:56:14.000+00:00,2017-06-15T14:56:14.000+00:00,2017-06-15T14:56:14.000+00:00,0
88
github:GithubDeployment:1:MDEwOkRlcGxveW1lbnQ0MjAwMzE5M7==,github:GithubRepo:1:134018330,7bc32d9148e612b54c1909ecf56a62a08cb7b0e7,,IN_PROGRESS,github-pages,2017-06-26T18:03:49.000+00:00,2017-06-26T18:03:49.000+00:00,2017-06-26T18:03:49.000+00:00,0
99
github:GithubDeployment:1:MDEwOkRlcGxveW1lbnQ0MjM3NTU0M8==,github:GithubRepo:1:134018330,6941c84de27d8a306510af3a03812b26ec421725,,OTHER,github-pages,2017-06-29T15:13:53.000+00:00,2017-06-29T15:13:53.000+00:00,2017-06-29T15:13:53.000+00:00,0
10-
github:GithubDeployment:1:MDEwOkRlcGxveW1lbnQ0MzY0MzQ1N9==,github:GithubRepo:1:134018330,5f0258bc04265e1f46e5eb7f685d91a0a7075031,,OTHER,github-pages,2017-07-11T13:09:32.000+00:00,2017-07-11T13:09:32.000+00:00,2017-07-11T13:09:32.000+00:00,0
11-
github:GithubDeployment:1:MDEwOkRlcGxveW1lbnQ0NTQ3OTQ4O0==,github:GithubRepo:1:134018330,0be0c9ca727d106f85f126cf8beb10a6843af352,,OTHER,github-pages,2017-07-26T19:43:48.000+00:00,2017-07-26T19:43:48.000+00:00,2017-07-26T19:43:48.000+00:00,0
10+
github:GithubDeployment:1:MDEwOkRlcGxveW1lbnQ0MzY0MzQ1N9==,github:GithubRepo:1:134018330,5f0258bc04265e1f46e5eb7f685d91a0a7075031,SUCCESS,DONE,github-pages,2017-07-11T13:09:32.000+00:00,2017-07-11T13:09:32.000+00:00,2017-07-11T13:09:32.000+00:00,0
11+
github:GithubDeployment:1:MDEwOkRlcGxveW1lbnQ0NTQ3OTQ4O0==,github:GithubRepo:1:134018330,0be0c9ca727d106f85f126cf8beb10a6843af352,SUCCESS,DONE,github-pages,2017-07-26T19:43:48.000+00:00,2017-07-26T19:43:48.000+00:00,2017-07-26T19:43:48.000+00:00,0
1212
github:GithubDeployment:1:MDEwOkRlcGxveW1lbnQ0NTQ4MDI010==,github:GithubRepo:1:134018330,8faba4cb2f03fa56ab6671d58f46d44622f36561,,OTHER,github-pages,2017-07-26T19:50:31.000+00:00,2017-07-26T19:50:31.000+00:00,2017-07-26T19:50:31.000+00:00,0

‎backend/plugins/github/tasks/deployment_convertor.go‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -78,12 +78,12 @@ func ConvertDeployment(taskCtx plugin.SubTaskContext) errors.Error {
7878
CicdScopeId: deploymentScopeIdGen.Generate(githubDeployment.ConnectionId, githubDeployment.GithubId),
7979
Name: githubDeployment.CommitOid,
8080
Result: devops.GetResult(&devops.ResultRule{
81-
Success: []string{StatusSuccess},
81+
Success: []string{StatusSuccess, StatusInactive, StatusActive},
8282
Failure: []string{StatusError, StatusFailure},
8383
Default: devops.RESULT_DEFAULT,
8484
}, githubDeployment.State),
8585
Status: devops.GetStatus(&devops.StatusRule{
86-
Done: []string{StatusSuccess, StatusError, StatusFailure},
86+
Done: []string{StatusSuccess, StatusError, StatusFailure, StatusInactive, StatusActive},
8787
InProgress: []string{StatusInProgress, StatusQueued, StatusWaiting, StatusPending},
8888
Default: devops.STATUS_OTHER,
8989
}, githubDeployment.State),

0 commit comments

Comments
 (0)