Skip to content
This repository was archived by the owner on Mar 3, 2023. It is now read-only.

Commit b98c9e6

Browse files
huijunwuhuijunw
authored andcommitted
Fix flaky test IntegrationTest_MultiSpoutsMultiTasks (#1815)
* fix flaky integration test MultiSpoutsMultiTasks * re-enable IntegrationTest_MultiSpoutsMultiTasks
1 parent 0fddad8 commit b98c9e6

2 files changed

Lines changed: 6 additions & 1 deletion

File tree

integration-test/src/java/com/twitter/heron/integration_test/core/IntegrationTestBolt.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,6 @@ private int calculateTerminalsToReceive(TopologyContext context) {
8181

8282
@Override
8383
public void execute(Tuple tuple) {
84-
tuplesReceived++;
8584
String streamID = tuple.getSourceStreamId();
8685

8786
LOG.info("Received a tuple: " + tuple + " ; from: " + streamID);
@@ -105,6 +104,7 @@ public void execute(Tuple tuple) {
105104
"Received a terminal, need to receive %s more", terminalsToReceive));
106105
}
107106
} else {
107+
tuplesReceived++;
108108
currentTupleProcessing = tuple;
109109
delegateBolt.execute(tuple);
110110
// We ack only the tuples in user's logic

integration-test/src/python/test_runner/resources/test.json

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -57,6 +57,11 @@
5757
"classPath" : "bolt_double_emit_tuples.BoltDoubleEmitTuples",
5858
"expectedResultRelativePath" : "bolt_double_emit_tuples/resources/BoltDoubleEmitTuples.json"
5959
},
60+
{
61+
"topologyName" : "IntegrationTest_MultiSpoutsMultiTasks",
62+
"classPath" : "multi_spouts_multi_tasks.MultiSpoutsMultiTasks",
63+
"expectedResultRelativePath" : "multi_spouts_multi_tasks/resources/MultiSpoutsMultiTasks.json"
64+
},
6065
{
6166
"topologyName" : "IntegrationTest_OneBoltMultiTasks",
6267
"classPath" : "one_bolt_multi_tasks.OneBoltMultiTasks",

0 commit comments

Comments
 (0)