remove setter in enum class

apache · Mar 8, 2025 · d0cd289 · d0cd289
1 parent 3a830c7
commit d0cd289
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 29 deletions.
diff --git a/common/src/main/java/org/apache/seata/common/result/Code.java b/common/src/main/java/org/apache/seata/common/result/Code.java
@@ -34,12 +34,12 @@ public enum Code {
     /**
      * The Code.
      */
-    public String code;
+    public final String code;
 
     /**
      * The Msg.
      */
-    public String msg;
+    public final String msg;
 
     private Code(String code, String msg) {
         this.code = code;
@@ -55,15 +55,6 @@ public String getCode() {
         return this.code;
     }
 
-    /**
-     * Sets code.
-     *
-     * @param code the code
-     */
-    public void setCode(String code) {
-        this.code = code;
-    }
-
     /**
      * Gets msg.
      *
@@ -73,15 +64,6 @@ public String getMsg() {
         return msg;
     }
 
-    /**
-     * Sets msg.
-     *
-     * @param msg the msg
-     */
-    public void setMsg(String msg) {
-        this.msg = msg;
-    }
-
     /**
      * Gets error msg.
      *

diff --git a/common/src/test/java/org/apache/seata/common/code/CodeTest.java b/common/src/test/java/org/apache/seata/common/code/CodeTest.java
@@ -39,13 +39,4 @@ public void testGetErrorMsgWithInvalidCodeReturnsNull() {
         // Test case for non-existing code
         assertNull(Code.getErrorMsg("404"));
     }
-
-    @Test
-    public void testSetCodeAndMsgUpdatesValuesCorrectly() {
-        // Test case to check if setCode and setMsg are working as expected
-        Code.SUCCESS.setCode("201");
-        Code.SUCCESS.setMsg("Created");
-        assertEquals("201", Code.SUCCESS.getCode());
-        assertEquals("Created", Code.SUCCESS.getMsg());
-    }
 }