support for observing metrics collected on seata client side #4878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix snapshot
robynron
changed the title
robynron
changed the title
|
This pull request introduces 7 alerts when merging 77ad527 into 06c2a50 - view on LGTM.com new alerts:
|
lvekee
suggested changes
Aug 28, 2022
metrics/seata-metrics-service/src/main/java/io/seata/metrics/TMMeterIdConstants.java
Show resolved
Hide resolved
| @@ -0,0 +1,30 @@ | |||
| package io.seata.metrics.service; | |||
|
|
||
| import io.seata.common.ConfigurationKeys; | ||
| import io.seata.config.ConfigurationFactory; | ||
| import io.seata.core.context.RootContext; |
| import java.util.concurrent.TimeUnit; | ||
| import java.util.function.Consumer; | ||
|
|
||
| import static io.seata.metrics.IdConstants.*; |
| import io.seata.core.event.BranchEvent; | ||
| import io.seata.core.event.GlobalTransactionEvent; | ||
| import io.seata.core.model.GlobalStatus; | ||
| import io.seata.metrics.IdConstants; |
|
|
||
| consumers.put(STATUS_VALUE_AFTER_COMMITTED_KEY, this::processAfterGlobalCommitted); | ||
| consumers.put(STATUS_VALUE_AFTER_ROLLBACKED_KEY, this::processAfterGlobalRollbacked); | ||
| }else if (MetricsManager.get().getRole().equals(MetricsManager.get().ROLE_VALUE_CLIENT)) { |
| @Subscribe | ||
| public void recordGlobalTransactionEventForMetrics(GlobalTransactionEvent event) { | ||
| if (registry != null) { | ||
| if (consumers.containsKey(event.getMetricEvent())){ |
metrics/seata-metrics-service/src/main/java/io/seata/metrics/RMMeterIdConstants.java
Show resolved
Hide resolved
| import io.seata.metrics.Id; | ||
| import io.seata.metrics.IdConstants; |
lvekee
suggested changes
Aug 28, 2022
| @@ -28,6 +28,7 @@ | |||
| import io.seata.core.model.BranchType; | |||
| import io.seata.core.model.Resource; | |||
| import io.seata.core.model.ResourceManager; | |||
| import io.seata.metrics.service.MetricsPublisher; | |||
| @@ -112,6 +113,7 @@ public boolean lockQuery(BranchType branchType, String resourceId, | |||
| @Override | |||
| public void registerResource(Resource resource) { | |||
| getResourceManager(resource.getBranchType()).registerResource(resource); | |||
|
|
|||
Codecov Report
@@ Coverage Diff @@
## develop #4878 +/- ##
=============================================
- Coverage 49.23% 48.50% -0.73%
+ Complexity 4117 4084 -33
=============================================
Files 737 740 +3
Lines 25827 26757 +930
Branches 3193 3191 -2
=============================================
+ Hits 12715 12979 +264
- Misses 11764 12433 +669
+ Partials 1348 1345 -3
|
robynron
changed the title
|
|
|
Due to code conflicts and age, if you are still interested in participating in the community, please resubmit this pr to the 2.x branch after resolving the conflict. |
|
好的，我后面基于2.x分支重新弄一下 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
Improved the monitoring of various data on the Seata Client side. Help users effectively monitor the execution process and identify possible problems.
Ⅱ. Does this pull request fix one issue?
fixes #4637
Ⅲ. Why don't you add test cases (unit test/integration test)?
I'll add later.
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews