OAK-11560 rename method, make configuration private

Author: joerghoh

oak-segment-remote/src/main/java/org/apache/jackrabbit/oak/segment/remote/persistentcache/PersistentDiskCache.java

@@ -60,7 +60,7 @@ public class PersistentDiskCache extends AbstractPersistentCache {
     public static final long DEFAULT_TEMP_FILES_CLEANUP_WAIT_TIME_MS = 60000;
     private static final String TEMP_FILE_SUFFIX = ".part";
 
-    public static boolean DELETE_SEGMENT_ON_REFETCH = Boolean.getBoolean("oak.segment.cache.delete_segment_on_refetch");
+    private static boolean DELETE_SEGMENT_ON_REFETCH = Boolean.getBoolean("oak.segment.cache.delete_segment_on_refetch");
 
     private final File directory;
     private final long maxCacheSizeBytes;
@@ -165,7 +165,7 @@ public void writeSegment(long msb, long lsb, Buffer buffer) {
                     diskCacheIOMonitor.updateCacheSize(cacheSizeAfter, fileSize);
                 } catch (FileAlreadyExistsException faee) {
                     if (DELETE_SEGMENT_ON_REFETCH) {
-                        writeSegmentExceptionHandler(segmentId, segmentFile, tempSegmentFile, faee);
+                        deleteSegmentAndTempSegment(segmentId, segmentFile, tempSegmentFile, faee);
                     } else {
                         // just delete the temp file, as the target segment file is already there and valid
                         try {
@@ -176,7 +176,7 @@ public void writeSegment(long msb, long lsb, Buffer buffer) {
                         }
                     }
                 } catch (Exception e) {
-                    writeSegmentExceptionHandler(segmentId, segmentFile, tempSegmentFile, e);
+                    deleteSegmentAndTempSegment(segmentId, segmentFile, tempSegmentFile, e);
                 } finally {
                     writesPending.remove(segmentId);
                 }
@@ -187,7 +187,7 @@ public void writeSegment(long msb, long lsb, Buffer buffer) {
         executor.execute(task);
     }
 
-    private void writeSegmentExceptionHandler(String segmentId, File segmentFile, File tempSegmentFile, Exception e) {
+    private void deleteSegmentAndTempSegment(String segmentId, File segmentFile, File tempSegmentFile, Exception e) {
         logger.error("Error writing segment {} to cache", segmentId, e);
         try {
             Files.deleteIfExists(segmentFile.toPath());