Skip to content

Commit db447dc

Browse files
authored
Merge pull request #1969 from apache/OAK-11374
OAK-11374 : removed usage of Guava's Maps.immutableEntry
2 parents 4b91ac5 + 158832c commit db447dc

File tree

3 files changed

+5
-10
lines changed

3 files changed

+5
-10
lines changed

oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/MissingBcSweeper2.java

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,10 +20,9 @@
2020
import static org.apache.jackrabbit.guava.common.collect.Iterables.filter;
2121
import static org.apache.jackrabbit.guava.common.collect.Iterables.partition;
2222
import static org.apache.jackrabbit.guava.common.collect.Iterables.transform;
23-
import static org.apache.jackrabbit.guava.common.collect.Maps.immutableEntry;
24-
2523
import static org.apache.jackrabbit.oak.plugins.document.util.Utils.COMMITROOT_OR_REVISIONS;
2624

25+
import java.util.AbstractMap.SimpleImmutableEntry;
2726
import java.util.Collections;
2827
import java.util.HashMap;
2928
import java.util.LinkedList;
@@ -158,7 +157,7 @@ public Map.Entry<Path, UpdateOp> apply(NodeDocument doc) {
158157
lastYield = context.getClock().getTime();
159158
yieldCnt = 0;
160159
}
161-
return immutableEntry(doc.getPath(), sweepOne(doc));
160+
return new SimpleImmutableEntry<>(doc.getPath(), sweepOne(doc));
162161
}
163162
}::apply), input -> input.getValue() != null);
164163
}

oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/NodeDocumentSweeper.java

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@
1616
*/
1717
package org.apache.jackrabbit.oak.plugins.document;
1818

19+
import java.util.AbstractMap.SimpleImmutableEntry;
1920
import java.util.HashMap;
2021
import java.util.List;
2122
import java.util.Map;
@@ -33,8 +34,6 @@
3334
import static org.apache.jackrabbit.guava.common.collect.Iterables.filter;
3435
import static org.apache.jackrabbit.guava.common.collect.Iterables.partition;
3536
import static org.apache.jackrabbit.guava.common.collect.Iterables.transform;
36-
import static org.apache.jackrabbit.guava.common.collect.Maps.immutableEntry;
37-
3837
import static org.apache.jackrabbit.oak.plugins.document.NodeDocument.isDeletedEntry;
3938
import static org.apache.jackrabbit.oak.plugins.document.NodeDocument.removeCommitRoot;
4039
import static org.apache.jackrabbit.oak.plugins.document.NodeDocument.removeRevision;
@@ -164,7 +163,7 @@ private Revision performSweep(Iterable<NodeDocument> documents,
164163

165164
private Iterable<Map.Entry<Path, UpdateOp>> sweepOperations(
166165
final Iterable<NodeDocument> docs) {
167-
return filter(transform(docs, doc -> immutableEntry(doc.getPath(), sweepOne(doc))),
166+
return filter(transform(docs, doc -> new SimpleImmutableEntry<>(doc.getPath(), sweepOne(doc))),
168167
input -> input.getValue() != null);
169168
}
170169

oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/VersionGarbageCollector.java

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -43,10 +43,7 @@
4343
import java.util.stream.StreamSupport;
4444

4545
import org.apache.jackrabbit.guava.common.base.Stopwatch;
46-
4746
import org.apache.jackrabbit.guava.common.collect.Iterators;
48-
import org.apache.jackrabbit.guava.common.collect.Maps;
49-
5047
import org.apache.jackrabbit.oak.commons.sort.StringSort;
5148
import org.apache.jackrabbit.oak.plugins.document.UpdateOp.Key;
5249
import org.apache.jackrabbit.oak.plugins.document.UpdateOp.Operation;
@@ -2550,7 +2547,7 @@ private Map.Entry<String, Long> parseEntry(String entry) throws IllegalArgumentE
25502547
} catch (NumberFormatException e) {
25512548
throw new IllegalArgumentException(entry);
25522549
}
2553-
return Maps.immutableEntry(id, modified);
2550+
return Map.entry(id, modified);
25542551
}
25552552
}
25562553

0 commit comments

Comments
 (0)