Skip to content

Commit e0b66f0

Browse files
author
Rishabh Kumar
committed
OAK-11384 : removed usage of Guava's Maps.difference
1 parent d2cb1e2 commit e0b66f0

File tree

4 files changed

+14
-9
lines changed

4 files changed

+14
-9
lines changed

oak-core/src/test/java/org/apache/jackrabbit/oak/security/authentication/AuthenticationConfigurationImplOSGiTest.java

Lines changed: 14 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -16,9 +16,7 @@
1616
*/
1717
package org.apache.jackrabbit.oak.security.authentication;
1818

19-
import org.apache.jackrabbit.guava.common.collect.Maps;
2019
import org.apache.jackrabbit.oak.AbstractSecurityTest;
21-
import org.apache.jackrabbit.oak.osgi.OsgiUtil;
2220
import org.apache.jackrabbit.oak.spi.security.ConfigurationParameters;
2321
import org.apache.sling.testing.mock.osgi.junit.OsgiContext;
2422
import org.junit.Rule;
@@ -27,8 +25,10 @@
2725

2826
import javax.jcr.SimpleCredentials;
2927

28+
import java.util.Map;
29+
import java.util.Objects;
30+
3031
import static org.apache.jackrabbit.oak.spi.security.authentication.AuthenticationConfiguration.PARAM_APP_NAME;
31-
import static org.junit.Assert.assertEquals;
3232
import static org.junit.Assert.assertTrue;
3333

3434
public class AuthenticationConfigurationImplOSGiTest extends AbstractSecurityTest {
@@ -54,6 +54,16 @@ public void testGetParameters() {
5454
ConfigurationParameters expected = ConfigurationParameters.of(
5555
PARAM_APP_NAME, "name",
5656
Constants.SERVICE_PID, authenticationConfiguration.getClass().getName());
57-
assertTrue(Maps.difference(expected, authenticationConfiguration.getParameters()).areEqual());
57+
assertTrue(areEqual(expected, authenticationConfiguration.getParameters()));
58+
}
59+
60+
// helper methods
61+
private boolean areEqual(Map<String, Object> first, Map<String, Object> second) {
62+
if (first.size() != second.size()) {
63+
return false;
64+
}
65+
66+
return first.entrySet().stream()
67+
.allMatch(e -> Objects.equals(e.getValue(), second.get(e.getKey())));
5868
}
5969
}

oak-run-commons/src/main/java/org/apache/jackrabbit/oak/run/cli/BlobStoreFixtureProvider.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,6 @@
2929
import java.util.Map;
3030
import java.util.Properties;
3131

32-
import org.apache.jackrabbit.guava.common.collect.Maps;
3332
import org.apache.jackrabbit.guava.common.io.Closer;
3433
import org.apache.jackrabbit.guava.common.io.Files;
3534
import org.apache.commons.io.FileUtils;

oak-upgrade/src/main/java/org/apache/jackrabbit/oak/upgrade/cli/blob/AzureDataStoreFactory.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -41,8 +41,6 @@
4141
import org.apache.jackrabbit.oak.spi.blob.BlobStore;
4242
import org.apache.jackrabbit.oak.stats.DefaultStatisticsProvider;
4343
import org.apache.jackrabbit.oak.stats.StatisticsProvider;
44-
45-
import org.apache.jackrabbit.guava.common.collect.Maps;
4644
import org.apache.jackrabbit.guava.common.io.Closer;
4745
import org.apache.jackrabbit.guava.common.io.Files;
4846

oak-upgrade/src/main/java/org/apache/jackrabbit/oak/upgrade/cli/blob/S3DataStoreFactory.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,14 +32,12 @@
3232

3333
import javax.jcr.RepositoryException;
3434

35-
import org.apache.jackrabbit.guava.common.collect.Maps;
3635
import org.apache.commons.io.IOUtils;
3736
import org.apache.jackrabbit.core.data.DataStoreException;
3837
import org.apache.jackrabbit.oak.blob.cloud.s3.S3DataStore;
3938
import org.apache.jackrabbit.oak.commons.PropertiesUtil;
4039
import org.apache.jackrabbit.oak.plugins.blob.datastore.DataStoreBlobStore;
4140
import org.apache.jackrabbit.oak.spi.blob.BlobStore;
42-
4341
import org.apache.jackrabbit.guava.common.io.Closer;
4442
import org.apache.jackrabbit.guava.common.io.Files;
4543
import org.apache.jackrabbit.oak.stats.DefaultStatisticsProvider;

0 commit comments

Comments
 (0)