Skip to content

Commit b23af0d

Browse files
committed
JCR-4467: Remove all usage of java.security.acl.Group for Java 14
git-svn-id: https://svn.apache.org/repos/asf/jackrabbit/trunk@1866144 13f79535-47bb-0310-9956-ffa450edef68
1 parent 121539b commit b23af0d

File tree

8 files changed

+11
-23
lines changed

8 files changed

+11
-23
lines changed

Diff for: jackrabbit-core/src/main/java/org/apache/jackrabbit/core/security/principal/EveryonePrincipal.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@
2525
/**
2626
* The EveryonePrincipal contains all principals (excluding itself).
2727
*/
28-
public final class EveryonePrincipal implements java.security.acl.Group, GroupPrincipal, JackrabbitPrincipal {
28+
public final class EveryonePrincipal implements GroupPrincipal, JackrabbitPrincipal {
2929

3030
public static final String NAME = "everyone";
3131
private static final EveryonePrincipal INSTANCE = new EveryonePrincipal();

Diff for: jackrabbit-core/src/main/java/org/apache/jackrabbit/core/security/principal/GroupPrincipals.java

+1-8
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@
1717
package org.apache.jackrabbit.core.security.principal;
1818

1919
import java.security.Principal;
20-
import java.security.acl.Group;
2120
import java.util.Collections;
2221
import java.util.Enumeration;
2322

@@ -41,7 +40,7 @@ private GroupPrincipals() {
4140
* @return true if the principal is of type group.
4241
*/
4342
public static boolean isGroup(Principal principal) {
44-
return principal instanceof Group || principal instanceof GroupPrincipal;
43+
return principal instanceof GroupPrincipal;
4544
}
4645

4746
/**
@@ -50,9 +49,6 @@ public static boolean isGroup(Principal principal) {
5049
* @return an enumeration of the group members.
5150
*/
5251
public static Enumeration<? extends Principal> members(Principal principal) {
53-
if (principal instanceof Group) {
54-
return ((Group) principal).members();
55-
}
5652
if (principal instanceof GroupPrincipal) {
5753
return ((GroupPrincipal) principal).members();
5854
}
@@ -66,9 +62,6 @@ public static Enumeration<? extends Principal> members(Principal principal) {
6662
* @return true if the principal is a member of this group, false otherwise.
6763
*/
6864
public static boolean isMember(Principal principal, Principal member) {
69-
if (principal instanceof Group) {
70-
return ((Group) principal).isMember(member);
71-
}
7265
if (principal instanceof GroupPrincipal) {
7366
return ((GroupPrincipal) principal).isMember(member);
7467
}

Diff for: jackrabbit-core/src/main/java/org/apache/jackrabbit/core/security/principal/PrincipalManagerImpl.java

+1-2
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@
1717
package org.apache.jackrabbit.core.security.principal;
1818

1919
import java.security.Principal;
20-
import java.security.acl.Group;
2120
import java.util.ArrayList;
2221
import java.util.Collections;
2322
import java.util.Enumeration;
@@ -212,7 +211,7 @@ private Principal disguise(Principal principal, PrincipalProvider provider) {
212211
* due to the fact, that the principal provider is not bound to a particular
213212
* Session object.
214213
*/
215-
private class CheckedGroup implements Group, GroupPrincipal, JackrabbitPrincipal {
214+
private class CheckedGroup implements GroupPrincipal, JackrabbitPrincipal {
216215

217216
final Principal delegatee;
218217
private final PrincipalProvider provider;

Diff for: jackrabbit-core/src/main/java/org/apache/jackrabbit/core/security/user/GroupImpl.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -291,7 +291,7 @@ static PropertySequence getPropertySequence(Node nMembers, UserManagerImpl userM
291291
/**
292292
* Principal Implementation
293293
*/
294-
private class NodeBasedGroup extends NodeBasedPrincipal implements java.security.acl.Group, GroupPrincipal {
294+
private class NodeBasedGroup extends NodeBasedPrincipal implements GroupPrincipal {
295295

296296
private NodeBasedGroup(String name) {
297297
super(name);

Diff for: jackrabbit-jcr-rmi/src/main/java/org/apache/jackrabbit/rmi/client/principal/ClientGroup.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -20,10 +20,10 @@
2020

2121
import java.rmi.RemoteException;
2222
import java.security.Principal;
23-
import java.security.acl.Group;
2423
import java.util.Enumeration;
2524
import java.util.Iterator;
2625

26+
import org.apache.jackrabbit.api.security.principal.GroupPrincipal;
2727
import org.apache.jackrabbit.rmi.client.LocalAdapterFactory;
2828
import org.apache.jackrabbit.rmi.client.RemoteRuntimeException;
2929
import org.apache.jackrabbit.rmi.remote.RemoteIterator;
@@ -38,7 +38,7 @@
3838
* @see Group
3939
* @see RemoteGroup
4040
*/
41-
public class ClientGroup extends ClientPrincipal implements Group {
41+
public class ClientGroup extends ClientPrincipal implements GroupPrincipal {
4242

4343
private final LocalAdapterFactory factory;
4444

Diff for: jackrabbit-jcr-rmi/src/main/java/org/apache/jackrabbit/rmi/client/principal/package-info.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -14,5 +14,5 @@
1414
* See the License for the specific language governing permissions and
1515
* limitations under the License.
1616
*/
17-
@org.osgi.annotation.versioning.Version("3.1.0")
17+
@org.osgi.annotation.versioning.Version("4.0.0")
1818
package org.apache.jackrabbit.rmi.client.principal;

Diff for: jackrabbit-jcr-rmi/src/main/java/org/apache/jackrabbit/rmi/server/principal/ServerGroup.java

+3-7
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@
2020

2121
import java.rmi.RemoteException;
2222
import java.security.Principal;
23-
import java.security.acl.Group;
2423
import java.util.Collections;
2524
import java.util.Enumeration;
2625
import java.util.Iterator;
@@ -32,7 +31,7 @@
3231

3332
public class ServerGroup extends ServerPrincipal implements RemoteGroup {
3433

35-
public ServerGroup(final Group principal, final RemoteAdapterFactory factory)
34+
public ServerGroup(final GroupPrincipal principal, final RemoteAdapterFactory factory)
3635
throws RemoteException {
3736
super(principal, factory);
3837
}
@@ -81,16 +80,13 @@ private static boolean isMember(final String memberName, final Principal group)
8180
}
8281

8382
public static boolean isGroup(Principal principal) {
84-
return principal instanceof Group || principal instanceof GroupPrincipal;
83+
return principal instanceof GroupPrincipal;
8584
}
8685

8786
private static Enumeration<? extends Principal> members(Principal principal) {
88-
if (principal instanceof Group) {
89-
return ((Group) principal).members();
90-
}
9187
if (principal instanceof GroupPrincipal) {
9288
return ((GroupPrincipal) principal).members();
9389
}
9490
return Collections.emptyEnumeration();
9591
}
96-
}
92+
}

Diff for: jackrabbit-jcr-rmi/src/main/java/org/apache/jackrabbit/rmi/server/principal/package-info.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -14,5 +14,5 @@
1414
* See the License for the specific language governing permissions and
1515
* limitations under the License.
1616
*/
17-
@org.osgi.annotation.versioning.Version("3.1.0")
17+
@org.osgi.annotation.versioning.Version("4.0.0")
1818
package org.apache.jackrabbit.rmi.server.principal;

0 commit comments

Comments
 (0)