Skip to content

Commit 21340a4

Browse files
authored
KAFKA-20638 Use Locale.ROOT in ConsumerGroupCommand.toLowerCase() (#22415)
Fixes a checkstyle violation by explicitly passing `java.util.Locale.ROOT` to `toLowerCase()` inside `ConsumerGroupCommand.consumerGroupTypesFromString()`. This ensures consistent behavior across different server locales. Reviewers: Chia-Ping Tsai <chia7712@gmail.com>
1 parent f672256 commit 21340a4

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

tools/src/main/java/org/apache/kafka/tools/consumer/group/ConsumerGroupCommand.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -164,7 +164,7 @@ static Set<GroupState> groupStatesFromString(String input) {
164164
@SuppressWarnings("Regexp")
165165
static Set<GroupType> consumerGroupTypesFromString(String input) {
166166
Set<GroupType> validTypes = Set.of(GroupType.CLASSIC, GroupType.CONSUMER);
167-
Set<GroupType> parsedTypes = Stream.of(input.toLowerCase().split(",")).map(s -> GroupType.parse(s.trim())).collect(Collectors.toSet());
167+
Set<GroupType> parsedTypes = Stream.of(input.toLowerCase(java.util.Locale.ROOT).split(",")).map(s -> GroupType.parse(s.trim())).collect(Collectors.toSet());
168168
if (!validTypes.containsAll(parsedTypes)) {
169169
throw new IllegalArgumentException("Invalid types list '" + input + "'. Valid types are: " +
170170
String.join(", ", validTypes.stream().map(GroupType::toString).collect(Collectors.toSet())));

0 commit comments

Comments
 (0)