Skip to content

Commit 5d86a6b

Browse files
MINOR: Remove unnecessary null check in DefaultStatePersister#stop (#22308)
The `stateManager` field is `final` and assigned in both constructors of `DefaultStatePersister`, so the `if (stateManager != null)` guard in `stop()` can never evaluate to false. No behavior change; existing tests in `DefaultStatePersisterTest` remain sufficient. Reviewers: Ken Huang <s7133700@gmail.com>, Chia-Ping Tsai <chia7712@gmail.com>
1 parent 23436ab commit 5d86a6b

1 file changed

Lines changed: 1 addition & 3 deletions

File tree

server-common/src/main/java/org/apache/kafka/server/share/persister/DefaultStatePersister.java

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -69,9 +69,7 @@ private void start() {
6969
@Override
7070
public void stop() {
7171
try {
72-
if (stateManager != null) {
73-
stateManager.stop();
74-
}
72+
stateManager.stop();
7573
} catch (Exception e) {
7674
log.error("Unable to stop state manager", e);
7775
}

0 commit comments

Comments
 (0)