Skip to content

Commit 603d403

Browse files
jiafu1115stroller.fu
authored andcommitted
improve the test with renaming
Signed-off-by: stroller.fu <stroller.fu@zoom.us>
1 parent 9cfbc5e commit 603d403

1 file changed

Lines changed: 8 additions & 8 deletions

File tree

core/src/test/scala/unit/kafka/server/DynamicBrokerConfigTest.scala

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -776,30 +776,30 @@ class DynamicBrokerConfigTest {
776776
verifyIncorrectRemoteCopyLagProps(
777777
retentionMs = 1000L,
778778
logLocalRetentionMs = -2L,
779-
remoteCopyLagMs = 1001L,
779+
logRemoteCopyLagMs = 1001L,
780780
retentionBytes = 1000L,
781781
logLocalRetentionBytes = -2L,
782-
remoteCopyLagBytes = 100L
782+
logRemoteCopyLagBytes = 100L
783783
)
784784

785785
// remote copy lag bytes cannot exceed effective local retention bytes
786786
verifyIncorrectRemoteCopyLagProps(
787787
retentionMs = 1000L,
788788
logLocalRetentionMs = -2L,
789-
remoteCopyLagMs = 100L,
789+
logRemoteCopyLagMs = 100L,
790790
retentionBytes = 1000L,
791791
logLocalRetentionBytes = -2L,
792-
remoteCopyLagBytes = 1001L
792+
logRemoteCopyLagBytes = 1001L
793793
)
794794

795795
}
796796

797797
def verifyIncorrectRemoteCopyLagProps(retentionMs: Long,
798798
logLocalRetentionMs: Long,
799-
remoteCopyLagMs: Long,
799+
logRemoteCopyLagMs: Long,
800800
retentionBytes: Long,
801801
logLocalRetentionBytes: Long,
802-
remoteCopyLagBytes: Long): Unit = {
802+
logRemoteCopyLagBytes: Long): Unit = {
803803
val props = TestUtils.createBrokerConfig(0, port = 8181)
804804
props.put(ServerLogConfigs.LOG_RETENTION_TIME_MILLIS_CONFIG, retentionMs.toString)
805805
props.put(ServerLogConfigs.LOG_RETENTION_BYTES_CONFIG, retentionBytes.toString)
@@ -810,9 +810,9 @@ class DynamicBrokerConfigTest {
810810

811811
val newProps = new Properties()
812812
newProps.put(RemoteLogManagerConfig.LOG_LOCAL_RETENTION_MS_PROP, logLocalRetentionMs.toString)
813-
newProps.put(RemoteLogManagerConfig.LOG_REMOTE_COPY_LAG_MS_PROP, remoteCopyLagMs.toString)
813+
newProps.put(RemoteLogManagerConfig.LOG_REMOTE_COPY_LAG_MS_PROP, logRemoteCopyLagMs.toString)
814814
newProps.put(RemoteLogManagerConfig.LOG_LOCAL_RETENTION_BYTES_PROP, logLocalRetentionBytes.toString)
815-
newProps.put(RemoteLogManagerConfig.LOG_REMOTE_COPY_LAG_BYTES_PROP, remoteCopyLagBytes.toString)
815+
newProps.put(RemoteLogManagerConfig.LOG_REMOTE_COPY_LAG_BYTES_PROP, logRemoteCopyLagBytes.toString)
816816
// validate default config
817817
assertThrows(classOf[ConfigException], () => config.dynamicConfig.validate(newProps, perBrokerConfig = false))
818818
// validate per broker config

0 commit comments

Comments
 (0)