@@ -771,35 +771,35 @@ class DynamicBrokerConfigTest {
771771 }
772772
773773 @ Test
774- def testDynamicRemoteCopyLagThrowsOnIncorrectConfig (): Unit = {
775- // remote copy lag ms cannot exceed effective local retention ms
776- verifyIncorrectRemoteCopyLagProps (
774+ def testDynamicLogRemoteCopyLagThrowsOnIncorrectConfig (): Unit = {
775+ // log remote copy lag ms cannot exceed effective log local retention ms
776+ verifyIncorrectLogRemoteCopyLagProps (
777777 retentionMs = 1000L ,
778778 logLocalRetentionMs = - 2L ,
779- remoteCopyLagMs = 1001L ,
779+ logRemoteCopyLagMs = 1001L ,
780780 retentionBytes = 1000L ,
781781 logLocalRetentionBytes = - 2L ,
782- remoteCopyLagBytes = 100L
782+ logRemoteCopyLagBytes = 100L
783783 )
784784
785- // remote copy lag bytes cannot exceed effective local retention bytes
786- verifyIncorrectRemoteCopyLagProps (
785+ // log remote copy lag bytes cannot exceed effective log local retention bytes
786+ verifyIncorrectLogRemoteCopyLagProps (
787787 retentionMs = 1000L ,
788788 logLocalRetentionMs = - 2L ,
789- remoteCopyLagMs = 100L ,
789+ logRemoteCopyLagMs = 100L ,
790790 retentionBytes = 1000L ,
791791 logLocalRetentionBytes = - 2L ,
792- remoteCopyLagBytes = 1001L
792+ logRemoteCopyLagBytes = 1001L
793793 )
794794
795795 }
796796
797- def verifyIncorrectRemoteCopyLagProps (retentionMs : Long ,
798- logLocalRetentionMs : Long ,
799- remoteCopyLagMs : Long ,
800- retentionBytes : Long ,
801- logLocalRetentionBytes : Long ,
802- remoteCopyLagBytes : Long ): Unit = {
797+ def verifyIncorrectLogRemoteCopyLagProps (retentionMs : Long ,
798+ logLocalRetentionMs : Long ,
799+ logRemoteCopyLagMs : Long ,
800+ retentionBytes : Long ,
801+ logLocalRetentionBytes : Long ,
802+ logRemoteCopyLagBytes : Long ): Unit = {
803803 val props = TestUtils .createBrokerConfig(0 , port = 8181 )
804804 props.put(ServerLogConfigs .LOG_RETENTION_TIME_MILLIS_CONFIG , retentionMs.toString)
805805 props.put(ServerLogConfigs .LOG_RETENTION_BYTES_CONFIG , retentionBytes.toString)
@@ -810,9 +810,9 @@ class DynamicBrokerConfigTest {
810810
811811 val newProps = new Properties ()
812812 newProps.put(RemoteLogManagerConfig .LOG_LOCAL_RETENTION_MS_PROP , logLocalRetentionMs.toString)
813- newProps.put(RemoteLogManagerConfig .LOG_REMOTE_COPY_LAG_MS_PROP , remoteCopyLagMs .toString)
813+ newProps.put(RemoteLogManagerConfig .LOG_REMOTE_COPY_LAG_MS_PROP , logRemoteCopyLagMs .toString)
814814 newProps.put(RemoteLogManagerConfig .LOG_LOCAL_RETENTION_BYTES_PROP , logLocalRetentionBytes.toString)
815- newProps.put(RemoteLogManagerConfig .LOG_REMOTE_COPY_LAG_BYTES_PROP , remoteCopyLagBytes .toString)
815+ newProps.put(RemoteLogManagerConfig .LOG_REMOTE_COPY_LAG_BYTES_PROP , logRemoteCopyLagBytes .toString)
816816 // validate default config
817817 assertThrows(classOf [ConfigException ], () => config.dynamicConfig.validate(newProps, perBrokerConfig = false ))
818818 // validate per broker config
0 commit comments