Skip to content

Commit 6b18fee

Browse files
committed
Address feedback from Jun
1 parent 174feec commit 6b18fee

File tree

37 files changed

+178
-172
lines changed

37 files changed

+178
-172
lines changed

build.gradle

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1990,6 +1990,7 @@ project(':clients:clients-integration-tests') {
19901990
testImplementation project(':test-common:test-common-internal-api')
19911991
testImplementation project(':test-common:test-common-runtime')
19921992
testImplementation project(':metadata')
1993+
testImplementation project(':raft')
19931994
testImplementation project(':server')
19941995
testImplementation project(':storage')
19951996
testImplementation project(':core').sourceSets.test.output
@@ -3555,6 +3556,7 @@ project(':connect:runtime') {
35553556
testImplementation project(':test-common:test-common-internal-api')
35563557
testImplementation project(':test-common:test-common-util')
35573558
testImplementation project(':test-common:test-common-runtime')
3559+
testImplementation project(':raft')
35583560
testImplementation project(':server-common')
35593561
testImplementation project(':server')
35603562
testImplementation project(':group-coordinator')
@@ -3779,6 +3781,7 @@ project(':connect:mirror') {
37793781
testImplementation project(':connect:runtime').sourceSets.test.output
37803782
testImplementation project(':core')
37813783
testImplementation project(':test-common:test-common-runtime')
3784+
testImplementation project(':raft')
37823785
testImplementation project(':server')
37833786
testImplementation project(':server-common')
37843787

checkstyle/import-control.xml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -580,6 +580,9 @@
580580
<allow pkg="org.apache.kafka.server.config" />
581581
<allow pkg="org.apache.logging.log4j" />
582582
<allow pkg="kafka.server" />
583+
<subpackage name="integration">
584+
<allow pkg="org.apache.kafka.raft" />
585+
</subpackage>
583586
<subpackage name="rest">
584587
<allow pkg="jakarta.ws.rs" />
585588
<allow pkg="jakarta.inject" />
@@ -665,6 +668,7 @@
665668
<allow pkg="org.apache.http"/>
666669
<allow pkg="org.eclipse.jetty.util"/>
667670
<!-- for tests -->
671+
<allow pkg="org.apache.kafka.raft" />
668672
<allow pkg="org.apache.kafka.server.util" />
669673
<allow pkg="org.apache.kafka.server.config" />
670674
<allow pkg="kafka.server"/>

clients/clients-integration-tests/src/test/java/org/apache/kafka/clients/admin/StaticBrokerConfigTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@
2828
import org.apache.kafka.common.test.api.Type;
2929
import org.apache.kafka.coordinator.group.GroupConfig;
3030
import org.apache.kafka.coordinator.group.GroupCoordinatorConfig;
31-
import org.apache.kafka.server.config.KRaftConfigs;
31+
import org.apache.kafka.raft.KRaftConfigs;
3232
import org.apache.kafka.server.config.ServerConfigs;
3333
import org.apache.kafka.server.metrics.ClientMetricsConfigs;
3434
import org.apache.kafka.storage.internals.log.LogConfig;

connect/mirror/src/test/java/org/apache/kafka/connect/mirror/integration/MirrorConnectorsWithCustomForwardingAdminIntegrationTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@
3535
import org.apache.kafka.connect.mirror.clients.admin.FakeLocalMetadataStore;
3636
import org.apache.kafka.connect.util.clusters.EmbeddedKafkaCluster;
3737
import org.apache.kafka.network.SocketServerConfigs;
38-
import org.apache.kafka.server.config.KRaftConfigs;
38+
import org.apache.kafka.raft.KRaftConfigs;
3939
import org.apache.kafka.server.config.ServerConfigs;
4040

4141
import org.junit.jupiter.api.AfterEach;

connect/runtime/src/test/java/org/apache/kafka/connect/integration/ExactlyOnceSourceIntegrationTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@
5353
import org.apache.kafka.connect.util.clusters.EmbeddedConnectCluster;
5454
import org.apache.kafka.connect.util.clusters.EmbeddedKafkaCluster;
5555
import org.apache.kafka.network.SocketServerConfigs;
56-
import org.apache.kafka.server.config.KRaftConfigs;
56+
import org.apache.kafka.raft.KRaftConfigs;
5757
import org.apache.kafka.server.config.ServerConfigs;
5858
import org.apache.kafka.test.NoRetryException;
5959

core/src/main/scala/kafka/server/KafkaConfig.scala

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,13 +39,13 @@ import org.apache.kafka.coordinator.group.modern.share.ShareGroupConfig
3939
import org.apache.kafka.coordinator.group.{GroupConfig, GroupCoordinatorConfig}
4040
import org.apache.kafka.coordinator.share.ShareCoordinatorConfig
4141
import org.apache.kafka.network.SocketServerConfigs
42-
import org.apache.kafka.raft.{MetadataLogConfig, QuorumConfig}
42+
import org.apache.kafka.raft.{KRaftConfigs, MetadataLogConfig, QuorumConfig}
4343
import org.apache.kafka.security.authorizer.AuthorizerUtils
4444
import org.apache.kafka.server.ProcessRole
4545
import org.apache.kafka.server.authorizer.Authorizer
4646
import org.apache.kafka.server.common.MetadataVersion
4747
import org.apache.kafka.server.config.AbstractKafkaConfig.getMap
48-
import org.apache.kafka.server.config.{AbstractKafkaConfig, KRaftConfigs, QuotaConfig, ReplicationConfigs, ServerConfigs, ServerLogConfigs}
48+
import org.apache.kafka.server.config.{AbstractKafkaConfig, QuotaConfig, ReplicationConfigs, ServerConfigs, ServerLogConfigs}
4949
import org.apache.kafka.server.log.remote.storage.RemoteLogManagerConfig
5050
import org.apache.kafka.server.metrics.MetricConfigs
5151
import org.apache.kafka.storage.internals.log.{CleanerConfig, LogConfig}

core/src/main/scala/kafka/tools/TestRaftServer.scala

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,12 +37,11 @@ import org.apache.kafka.common.security.token.delegation.internals.DelegationTok
3737
import org.apache.kafka.common.utils.{Exit, Time, Utils}
3838
import org.apache.kafka.common.{TopicPartition, Uuid, protocol}
3939
import org.apache.kafka.raft.errors.NotLeaderException
40-
import org.apache.kafka.raft.{Batch, BatchReader, Endpoints, LeaderAndEpoch, QuorumConfig, RaftClient}
40+
import org.apache.kafka.raft.{Batch, BatchReader, Endpoints, KRaftConfigs, LeaderAndEpoch, QuorumConfig, RaftClient}
4141
import org.apache.kafka.security.CredentialProvider
4242
import org.apache.kafka.server.SimpleApiVersionManager
4343
import org.apache.kafka.server.common.{FinalizedFeatures, MetadataVersion}
4444
import org.apache.kafka.server.common.serialization.RecordSerde
45-
import org.apache.kafka.server.config.KRaftConfigs
4645
import org.apache.kafka.server.fault.ProcessTerminatingFaultHandler
4746
import org.apache.kafka.server.util.{CommandDefaultOptions, CommandLineUtils, ShutdownableThread}
4847
import org.apache.kafka.snapshot.SnapshotReader

core/src/test/java/kafka/server/handlers/DescribeTopicPartitionsRequestHandlerTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,12 +60,12 @@
6060
import org.apache.kafka.metadata.LeaderRecoveryState;
6161
import org.apache.kafka.network.SocketServerConfigs;
6262
import org.apache.kafka.network.metrics.RequestChannelMetrics;
63+
import org.apache.kafka.raft.KRaftConfigs;
6364
import org.apache.kafka.raft.QuorumConfig;
6465
import org.apache.kafka.server.authorizer.Action;
6566
import org.apache.kafka.server.authorizer.AuthorizationResult;
6667
import org.apache.kafka.server.authorizer.Authorizer;
6768
import org.apache.kafka.server.common.KRaftVersion;
68-
import org.apache.kafka.server.config.KRaftConfigs;
6969

7070
import org.junit.jupiter.api.Test;
7171

core/src/test/scala/integration/kafka/api/ConsumerBounceTest.scala

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,8 @@ import org.apache.kafka.common.message.FindCoordinatorRequestData
2626
import org.apache.kafka.common.protocol.Errors
2727
import org.apache.kafka.common.requests.{FindCoordinatorRequest, FindCoordinatorResponse}
2828
import org.apache.kafka.coordinator.group.GroupCoordinatorConfig
29-
import org.apache.kafka.server.config.{KRaftConfigs, ReplicationConfigs, ServerLogConfigs}
29+
import org.apache.kafka.raft.KRaftConfigs
30+
import org.apache.kafka.server.config.{ReplicationConfigs, ServerLogConfigs}
3031
import org.apache.kafka.server.util.ShutdownableThread
3132
import org.junit.jupiter.api.Assertions._
3233
import org.junit.jupiter.api.{AfterEach, Disabled, TestInfo}

core/src/test/scala/integration/kafka/api/IntegrationTestHarness.scala

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,8 +31,8 @@ import org.apache.kafka.clients.admin.{Admin, AdminClientConfig}
3131
import org.apache.kafka.common.network.{ConnectionMode, ListenerName}
3232
import org.apache.kafka.common.serialization.{ByteArrayDeserializer, ByteArraySerializer, Deserializer, Serializer}
3333
import org.apache.kafka.network.SocketServerConfigs
34-
import org.apache.kafka.raft.MetadataLogConfig
35-
import org.apache.kafka.server.config.{KRaftConfigs, ReplicationConfigs}
34+
import org.apache.kafka.raft.{KRaftConfigs, MetadataLogConfig}
35+
import org.apache.kafka.server.config.ReplicationConfigs
3636
import org.junit.jupiter.api.{AfterEach, BeforeEach, TestInfo}
3737

3838
import scala.collection.mutable

0 commit comments

Comments
 (0)