Skip to content

Commit d3a99ce

Browse files
committed
KAFKA-20619: ClusterTestExtensions skip jdk.internal.ref.CleanerImpl threads
Add "Cleaner-" to the list of Skipped thread prefixes in ClusterTestExtensions. It's the prefix of daemon threads of InnocuousThreadGroup used by jdk.internal.ref.CleanerImpl.
1 parent 89f3888 commit d3a99ce

1 file changed

Lines changed: 6 additions & 2 deletions

File tree

test-common/test-common-runtime/src/main/java/org/apache/kafka/common/test/junit/ClusterTestExtensions.java

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -108,10 +108,12 @@ public class ClusterTestExtensions implements TestTemplateInvocationContextProvi
108108
private static final String ATTACH_LISTENER_THREAD_PREFIX = "Attach Listener";
109109
private static final String PROCESS_REAPER_THREAD_PREFIX = "process reaper";
110110
private static final String RMI_THREAD_PREFIX = "RMI";
111+
private static final String JDK_INTERNAL_CLEANERIMPL_THREAD_PREFIX = "Cleaner-";
112+
111113
private static final String DETECT_THREAD_LEAK_KEY = "detectThreadLeak";
112114
private static final Set<String> SKIPPED_THREAD_PREFIX = Set.of(METRICS_METER_TICK_THREAD_PREFIX, SCALA_THREAD_PREFIX,
113115
FORK_JOIN_POOL_THREAD_PREFIX, JUNIT_THREAD_PREFIX, ATTACH_LISTENER_THREAD_PREFIX, PROCESS_REAPER_THREAD_PREFIX,
114-
RMI_THREAD_PREFIX, SystemTimer.SYSTEM_TIMER_THREAD_PREFIX);
116+
RMI_THREAD_PREFIX, SystemTimer.SYSTEM_TIMER_THREAD_PREFIX, JDK_INTERNAL_CLEANERIMPL_THREAD_PREFIX);
115117

116118
@Override
117119
public boolean supportsTestTemplate(ExtensionContext context) {
@@ -182,7 +184,9 @@ public void afterEach(ExtensionContext context) {
182184
}
183185
List<Thread> threads = detectThreadLeak.newThreads();
184186
assertTrue(threads.isEmpty(), "Thread leak detected: " +
185-
threads.stream().map(Thread::getName).collect(Collectors.joining(", ")));
187+
threads.stream().map(t -> {
188+
return t.getThreadGroup().getName() + "/" + t.getName();
189+
}).collect(Collectors.joining(", ")));
186190
}
187191
}
188192

0 commit comments

Comments
 (0)