KAFKA-20103 properties value assignment syntax changed to 'propName = value' (in order to comply with future requirements announced for Gradle 10)

[dejan2609]

ℹ️ Note for reviewers: skip to this comment: #21373 (comment)

---

Related link: https://docs.gradle.org/9.4.1/userguide/upgrading_version_8.html#groovy_space_assignment_syntax

JIRA ticket: KAFKA-20103

Reviewers: Shivamrut gshivamrut@gmail.com

[dejan2609]

FYI @chia7712

[github-actions]

A label of 'needs-attention' was automatically added to this PR in order to raise the
attention of the committers. Once this issue has been triaged, the triage label
should be removed to prevent this automation from happening again.

[github-actions]

A label of 'needs-attention' was automatically added to this PR in order to raise the
attention of the committers. Once this issue has been triaged, the triage label
should be removed to prevent this automation from happening again.

[github-actions]

A label of 'needs-attention' was automatically added to this PR in order to raise the
attention of the committers. Once this issue has been triaged, the triage label
should be removed to prevent this automation from happening again.

[github-actions]

A label of 'needs-attention' was automatically added to this PR in order to raise the
attention of the committers. Once this issue has been triaged, the triage label
should be removed to prevent this automation from happening again.

[dejan2609]

Demoting to a draft for a few days (weeks) until I get some time to doublecheck it.

[github-actions]

A label of 'needs-attention' was automatically added to this PR in order to raise the
attention of the committers. Once this issue has been triaged, the triage label
should be removed to prevent this automation from happening again.

[github-actions]

This PR is being marked as stale since it has not had any activity in 90 days. If you
would like to keep this PR alive, please leave a comment asking for a review. If the PR has
merge conflicts, update it with the latest from the base branch.

If you are having difficulty finding a reviewer, please reach out on the [mailing list](https://kafka.apache.org/contact).

If this PR is no longer valid or desired, please feel free to close it. If no activity occurs in the next 30 days, it will be automatically closed.

[github-actions]

A label of 'needs-attention' was automatically added to this PR in order to raise the
attention of the committers. Once this issue has been triaged, the triage label
should be removed to prevent this automation from happening again.

[Shivamrut]

Hi @dejan2609 I noticed this is still in draft and marked stale. I’d be happy to help get this PR completed/merged. Rebase on latest trunk, run ./gradlew releaseTarGz with --warning-mode all, and mark ready for review if you’re busy. Just offering to collaborate.
CC - @chia7712

[dejan2609]

Hi @Shivamrut ! Solution is actually working as expected (and I just rebased it onto trunk without a single conflict 🙂) but the real question is: should we try to merge it now or just before (during ?) Gradle major version upgrade from 9 to 10 ?

Prologue (why we need to do this at some point): https://docs.gradle.org/9.4.1/userguide/upgrading_version_8.html#groovy_space_assignment_syntax

These generated methods are now deprecated and will be removed in Gradle 10, and both propertyName value and propertyName(value) will stop working unless the explicit method propertyName is defined. Use explicit assignment propertyName = value instead.

Test procedure:

1. Current trunk state problem report after ./gradlew clean rTG execution - propName/value syntax related warnings are shown ⚠️:

2. This PR state problem report after `./gradlew clean rTG` execution - `propName/value` syntax related warnings are gone ✅:

What is your take on this @chia7712 ?

[Shivamrut]

Hi @dejan2609 I verified it locally and your changes fix propName/value syntax related warnings as expected.
I think you should merge this now as its a small mechanical change with no real risk, and waiting for Gradle 10 would just delay work that’s already done. Please correct me if Im wrong.

[dejan2609]

I see your point @Shivamrut, we could include this change into trunk now; however, deprecated propName/value syntax still could be used afterwards (until Gradle major version switches from 9 to 10, that is).

All-in-all, the question stays: should we merge it now or later ?
This is up to the owners/maintainers/committers to decide (I can't do it on my own, I am just a contributor).

@mimaison, @chia7712, @clolov: please squeeze some time and have your say 🙂