KAFKA-18760: Deprecate Optional<String> and return String from public Endpoint#listener #19191
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FrankYang0529
force-pushed
the
KAFKA-18760
branch
from
9a88650 to
576b3df
Compare
… EndPoint#listenerName Signed-off-by: PoAn Yang <[email protected]>
FrankYang0529
force-pushed
the
KAFKA-18760
branch
from
576b3df to
5a57f0b
Compare
parthbagda211
approved these changes
Mar 15, 2025
Signed-off-by: PoAn Yang <[email protected]>
Signed-off-by: PoAn Yang <[email protected]>
Signed-off-by: PoAn Yang <[email protected]>
Signed-off-by: PoAn Yang <[email protected]>
FrankYang0529
changed the title
FrankYang0529
changed the title
chia7712
reviewed
Apr 16, 2025
| /** | ||
| * @deprecated Since 4.1. Use {@link #listener()} instead. This function will be removed in 5.0. | ||
| */ | ||
| @Deprecated |
There was a problem hiding this comment.
@Deprecated(since = "4.1", forRemoval = true)
| */ | ||
| @Deprecated |
There was a problem hiding this comment.
@Deprecated(since = "4.1", forRemoval = true)
| public class Endpoint { | ||
|
|
||
| private final String listenerName; | ||
| private final SecurityProtocol securityProtocol; | ||
| private final String host; | ||
| private final int port; | ||
|
|
||
| public static String parseListenerName(String connectionString) { |
There was a problem hiding this comment.
it seems only KafkaConfig uses this helper. Could you please move it to the KafkaConfig instead of leaving it in this public APIs?
| * Returns the listener name of this endpoint. | ||
| */ | ||
| public String listener() { | ||
| return listenerName; |
There was a problem hiding this comment.
How about renaming it to listenerName for consistency?
Signed-off-by: PoAn Yang <[email protected]>
TaiJuWu
approved these changes
Apr 17, 2025
|
@FrankYang0529 please fix the conflicts |
|
@FrankYang0529 please fix the conflicts |
|
@FrankYang0529 please rebase code to include the fix |
frankvicky
approved these changes
Apr 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
org.apache.kafka.common.Endpoint#listenerName.
org.apache.kafka.common.Endpoint.
replace org.apache.kafka.clients.admin.RaftVoterEndpoint#name
Reviewers: TaiJuWu [email protected], TengYao Chi
[email protected], Chia-Ping Tsai [email protected]