KAFKA-18157: Consider UnsupportedVersionException child class to represent the case of unsupported fields#22405
Open
alanlau28 wants to merge 2 commits into
Open
KAFKA-18157: Consider UnsupportedVersionException child class to represent the case of unsupported fields#22405alanlau28 wants to merge 2 commits into
alanlau28 wants to merge 2 commits into
Conversation
…esent the case of unsupported fields
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira: https://issues.apache.org/jira/browse/KAFKA-18157
This is a rebase of #18072 onto current trunk, plus the additional scope requested
Add a new exception class,
UnsupportedProtocolFieldException, as asubclass of
UnsupportedVersionException, to provide a more specificmessage for unsupported fields.
ConsumerGroupHeartbeatRequest.Buildernow throwsUnsupportedProtocolFieldExceptionwhen
subscribedTopicRegexis set against a server that only supports v0.ConsumerHeartbeatRequestManagerusesinstanceof UnsupportedProtocolFieldExceptionto detect this case instead of comparing message strings. Any future field-validation
errors added to
ConsumerGroupHeartbeatRequest.Builderwill be caught by the sameinstanceofcheck automatically, but the error message propagated to the user will need tobe updated accordingly.