fix comments

Author: songqing

src/commands/cmd_stream.cc

@@ -566,17 +566,13 @@ class CommandXGroup : public Commander {
     }
 
     if (subcommand_ == "destroy") {
-      uint64_t delete_cnt = 0;
-      auto s = stream_db.DestroyGroup(ctx, stream_name_, group_name_, &delete_cnt);
+      bool destroyed = false;
+      auto s = stream_db.DestroyGroup(ctx, stream_name_, group_name_, &destroyed);
       if (!s.ok()) {
         return {Status::RedisExecErr, s.ToString()};
       }
 
-      if (delete_cnt > 0) {
-        *output = redis::Integer(1);
-      } else {
-        *output = redis::Integer(0);
-      }
+      *output = redis::Integer(destroyed ? 1 : 0);
     }
 
     if (subcommand_ == "createconsumer") {

src/types/redis_stream.cc

@@ -738,8 +738,8 @@ rocksdb::Status Stream::CreateGroup(engine::Context &ctx, const Slice &stream_na
 }
 
 rocksdb::Status Stream::DestroyGroup(engine::Context &ctx, const Slice &stream_name, const std::string &group_name,
-                                     uint64_t *delete_cnt) {
-  *delete_cnt = 0;
+                                     bool *destroyed) {
+  *destroyed = false;
   std::string ns_key = AppendNamespacePrefix(stream_name);
 
   StreamMetadata metadata;
@@ -782,7 +782,7 @@ rocksdb::Status Stream::DestroyGroup(engine::Context &ctx, const Slice &stream_n
     if (!s.ok()) return s;
   }
 
-  *delete_cnt = 1;
+  *destroyed = true;
   metadata.group_number -= 1;
   std::string metadata_bytes;
   metadata.Encode(&metadata_bytes);

src/types/redis_stream.h

@@ -42,7 +42,7 @@ class Stream : public SubKeyScanner {
   rocksdb::Status CreateGroup(engine::Context &ctx, const Slice &stream_name, const StreamXGroupCreateOptions &options,
                               const std::string &group_name);
   rocksdb::Status DestroyGroup(engine::Context &ctx, const Slice &stream_name, const std::string &group_name,
-                               uint64_t *delete_cnt);
+                               bool *destroyed);
   rocksdb::Status CreateConsumer(engine::Context &ctx, const Slice &stream_name, const std::string &group_name,
                                  const std::string &consumer_name, int *created_number);
   rocksdb::Status DestroyConsumer(engine::Context &ctx, const Slice &stream_name, const std::string &group_name,

tests/cppunit/types/stream_test.cc

@@ -2518,12 +2518,12 @@ TEST_F(RedisStreamTest, StreamConsumerGroupCreateAndDestroy) {
   std::string group_name = "TestGroup";
   auto s = stream_->CreateGroup(*ctx_, stream_name, create_options, group_name);
   EXPECT_TRUE(s.ok());
-  uint64_t delete_cnt = 0;
-  s = stream_->DestroyGroup(*ctx_, stream_name, group_name, &delete_cnt);
-  EXPECT_TRUE(delete_cnt != 0);
-  delete_cnt = 0;
-  s = stream_->DestroyGroup(*ctx_, stream_name, group_name, &delete_cnt);
-  EXPECT_TRUE(delete_cnt == 0);
+  bool destroyed = false;
+  s = stream_->DestroyGroup(*ctx_, stream_name, group_name, &destroyed);
+  EXPECT_TRUE(destroyed);
+  destroyed = false;
+  s = stream_->DestroyGroup(*ctx_, stream_name, group_name, &destroyed);
+  EXPECT_FALSE(destroyed);
 }
 
 TEST_F(RedisStreamTest, DestroyGroupCleansUpConsumersAndPelEntries) {
@@ -2557,15 +2557,15 @@ TEST_F(RedisStreamTest, DestroyGroupCleansUpConsumersAndPelEntries) {
   EXPECT_TRUE(s.ok());
   EXPECT_EQ(entries.size(), 2);
 
-  uint64_t delete_cnt = 0;
-  s = stream_->DestroyGroup(*ctx_, stream_name, group_name, &delete_cnt);
+  bool destroyed = false;
+  s = stream_->DestroyGroup(*ctx_, stream_name, group_name, &destroyed);
   EXPECT_TRUE(s.ok());
-  EXPECT_GT(delete_cnt, 0);
+  EXPECT_TRUE(destroyed);
 
   // Verify re-destroying the same group deletes nothing
-  delete_cnt = 0;
-  s = stream_->DestroyGroup(*ctx_, stream_name, group_name, &delete_cnt);
-  EXPECT_EQ(delete_cnt, 0);
+  destroyed = false;
+  s = stream_->DestroyGroup(*ctx_, stream_name, group_name, &destroyed);
+  EXPECT_FALSE(destroyed);
 
   // Verify stream entries are still intact after group destruction
   std::vector<redis::StreamEntry> remaining;
@@ -2623,10 +2623,10 @@ TEST_F(RedisStreamTest, DestroyGroupDoesNotAffectOtherGroups) {
   EXPECT_TRUE(s.ok());
 
   // Destroy group1
-  uint64_t delete_cnt = 0;
-  s = stream_->DestroyGroup(*ctx_, stream_name, group1, &delete_cnt);
+  bool destroyed = false;
+  s = stream_->DestroyGroup(*ctx_, stream_name, group1, &destroyed);
   EXPECT_TRUE(s.ok());
-  EXPECT_GT(delete_cnt, 0);
+  EXPECT_TRUE(destroyed);
 
   // Verify group2 still exists with its consumer
   std::vector<std::pair<std::string, redis::StreamConsumerGroupMetadata>> group_metadata;