Skip to content

Commit 2e6dfb6

Browse files
authored
Merge branch 'unstable' into twa_agg
2 parents 7e2e5e9 + 645e1a3 commit 2e6dfb6

6 files changed

Lines changed: 27 additions & 23 deletions

File tree

.github/workflows/kvrocks.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -329,8 +329,8 @@ jobs:
329329
run: pip install gcovr==5.0 # 5.1 is not supported
330330
if: ${{ matrix.sonarcloud }}
331331

332-
- name: Install sonar-scanner and build-wrapper
333-
uses: SonarSource/sonarcloud-github-c-cpp@v3
332+
- name: Install Build Wrapper
333+
uses: SonarSource/sonarqube-scan-action/install-build-wrapper@v6.0.0
334334
if: ${{ matrix.sonarcloud }}
335335

336336
- name: Build Kvrocks

.github/workflows/sonar.yaml

Lines changed: 18 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -33,8 +33,8 @@ jobs:
3333
repository: ${{ github.event.workflow_run.head_repository.full_name }}
3434
ref: ${{ github.event.workflow_run.head_sha }}
3535
fetch-depth: 0
36-
- name: Install sonar-scanner and build-wrapper
37-
uses: SonarSource/sonarcloud-github-c-cpp@v3
36+
- name: Install Build Wrapper
37+
uses: SonarSource/sonarqube-scan-action/install-build-wrapper@v6.0.0
3838
- name: 'Download code coverage'
3939
uses: actions/github-script@v7
4040
with:
@@ -66,18 +66,22 @@ jobs:
6666
with:
6767
python-version: 3.x
6868

69-
- name: Run sonar-scanner
70-
env:
71-
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
72-
SONAR_TOKEN: ${{ secrets.SONARCLOUD_TOKEN }}
69+
- name: Extract PR number
7370
run: |
7471
PR_NUMBER=$(jq -r '.number | select (.!=null)' sonarcloud-data/github-event.json)
75-
echo "The PR number is $PR_NUMBER"
72+
echo "PR_NUMBER=$PR_NUMBER" >> "$GITHUB_ENV"
73+
echo "The PR number is ${PR_NUMBER:-<none>}"
7674
77-
sonar-scanner \
78-
--define sonar.cfamily.build-wrapper-output="sonarcloud-data" \
79-
--define sonar.coverageReportPaths=sonarcloud-data/coverage.xml \
80-
--define sonar.projectKey=apache_kvrocks \
81-
--define sonar.organization=apache \
82-
--define sonar.scm.revision=${{ github.event.workflow_run.head_sha }} \
83-
--define sonar.pullrequest.key=$PR_NUMBER
75+
- name: SonarQube Scan
76+
uses: SonarSource/sonarqube-scan-action@v6.0.0
77+
env:
78+
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
79+
SONAR_TOKEN: ${{ secrets.SONARCLOUD_TOKEN }}
80+
with:
81+
args: >
82+
-Dsonar.cfamily.build-wrapper-output=sonarcloud-data
83+
-Dsonar.coverageReportPaths=sonarcloud-data/coverage.xml
84+
-Dsonar.projectKey=apache_kvrocks
85+
-Dsonar.organization=apache
86+
-Dsonar.scm.revision=${{ github.event.workflow_run.head_sha }}
87+
-Dsonar.pullrequest.key=${{ env.PR_NUMBER }}

cmake/jsoncons.cmake

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,8 +20,8 @@ include_guard()
2020
include(cmake/utils.cmake)
2121

2222
FetchContent_DeclareGitHubWithMirror(jsoncons
23-
danielaparker/jsoncons v1.4.3
24-
MD5=62dad69488c5618f56283ef14d6c1e16
23+
danielaparker/jsoncons v1.5.0
24+
MD5=34fabe18f29c4e5c514eaefb5bb50d09
2525
)
2626

2727
FetchContent_MakeAvailableWithArgs(jsoncons

cmake/modules/FindZLIB.cmake

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ if(zlib_SOURCE_DIR)
2222

2323
add_library(zlib_with_headers INTERFACE) # rocksdb use it
2424
target_include_directories(zlib_with_headers INTERFACE $<BUILD_INTERFACE:${zlib_SOURCE_DIR}> $<BUILD_INTERFACE:${zlib_BINARY_DIR}>)
25-
target_link_libraries(zlib_with_headers INTERFACE zlib)
25+
target_link_libraries(zlib_with_headers INTERFACE zlib-ng)
2626
add_library(ZLIB::ZLIB ALIAS zlib_with_headers)
27-
install(TARGETS zlib zlib_with_headers EXPORT RocksDBTargets) # export for install(...)
27+
install(TARGETS zlib-ng zlib_with_headers EXPORT RocksDBTargets) # export for install(...)
2828
endif()

cmake/zlib.cmake

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,8 +20,8 @@ include_guard()
2020
include(cmake/utils.cmake)
2121

2222
FetchContent_DeclareGitHubWithMirror(zlib
23-
zlib-ng/zlib-ng 2.2.4
24-
MD5=9fbaac3919af8d5a0ad5726ef9c7c30b
23+
zlib-ng/zlib-ng 2.3.2
24+
MD5=7818ea3f3ad80873674faf500fd12a0d
2525
)
2626

2727
FetchContent_MakeAvailableWithArgs(zlib

x.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@
3232
CMAKE_REQUIRE_VERSION = (3, 16, 0)
3333
CLANG_FORMAT_REQUIRED_VERSION = (18, 0, 0)
3434
CLANG_TIDY_REQUIRED_VERSION = (18, 0, 0)
35-
GOLANGCI_LINT_REQUIRED_VERSION = (2, 6, 0)
35+
GOLANGCI_LINT_REQUIRED_VERSION = (2, 7, 0)
3636

3737
SEMVER_REGEX = re.compile(
3838
r"""

0 commit comments

Comments
 (0)