TST: add config set and get test case

Author: git-hulk

src/redis_cmd.cc

@@ -209,7 +209,7 @@ class CommandConfig : public Commander {
     } else if (args_.size() == 4 && sub_command == "set") {
       Status s = config->Set(svr, args_[2], args_[3]);
       if (!s.IsOK()) {
-        *output = Redis::Error("ERR "+s.Msg());
+        *output = Redis::Error("CONFIG SET '"+args_[2]+"' error: "+s.Msg());
       } else {
         *output = Redis::SimpleString("OK");
       }

tests/config_test.cc

@@ -4,36 +4,94 @@
 #include <vector>
 #include <gtest/gtest.h>
 
-TEST(Config, Profiling) {
+TEST(Config, GetAndSet) {
   const char *path = "test.conf";
   Config config;
-  Server srv(nullptr, &config);
 
   config.Load(path);
-  std::map<std::string, std::string> cases = {
+  std::map<std::string, std::string> mutable_cases = {
+      {"timeout" , "1000"},
+      {"maxclients" , "2000"},
+      {"max-backup-to-keep" , "32"},
+      {"max-backup-keep-hours" , "4000"},
+      {"requirepass" , "mytest_requirepass"},
+      {"masterauth" , "mytest_masterauth"},
+      {"compact-cron" , "1 2 3 4 5"},
+      {"bgsave-cron" , "5 4 3 2 1"},
+      {"max-io-mb" , "5000"},
+      {"max-db-size" , "6000"},
+      {"max-replication-mb" , "7000"},
+      {"slave-serve-stale-data" , "no"},
+      {"slave-read-only" , "no"},
+      {"slave-priority" , "101"},
+      {"slowlog-log-slower-than" , "1234"},
+      {"slowlog-max-len" , "123"},
       {"profiling-sample-ratio" , "50"},
       {"profiling-sample-record-max-len" , "1"},
       {"profiling-sample-record-threshold-ms" , "50"},
       {"profiling-sample-commands" , "get,set"},
+
+      {"rocksdb.compression" , "no"},
+      {"rocksdb.max_open_files" , "1234"},
+      {"rocksdb.write_buffer_size" , "1234"},
+      {"rocksdb.max_write_buffer_number" , "1"},
+      {"rocksdb.max_background_compactions" , "2"},
+      {"rocksdb.max_sub_compactions" , "3"},
+      {"rocksdb.delayed_write_rate" , "1234"},
+      {"rocksdb.stats_dump_period_sec" , "600"},
+      {"rocksdb.compaction_readahead_size" , "1024"},
+      {"rocksdb.level0_slowdown_writes_trigger" , "50"},
   };
   std::vector<std::string> values;
-  for (const auto &iter : cases) {
-    config.Set(&srv, iter.first, iter.second);
+  for (const auto &iter : mutable_cases) {
+    auto s = config.Set(nullptr, iter.first, iter.second);
+    ASSERT_TRUE(s.IsOK());
     config.Get(iter.first, &values);
+    ASSERT_TRUE(s.IsOK());
     ASSERT_EQ(values.size(), 2);
     EXPECT_EQ(values[0], iter.first);
     EXPECT_EQ(values[1], iter.second);
   }
   ASSERT_TRUE(config.Rewrite().IsOK());
   config.Load(path);
-  for (const auto &iter : cases) {
-    config.Set(&srv, iter.first, iter.second);
+  for (const auto &iter : mutable_cases) {
+    auto s = config.Set(nullptr, iter.first, iter.second);
+    ASSERT_TRUE(s.IsOK());
     config.Get(iter.first, &values);
     ASSERT_EQ(values.size(), 2);
     EXPECT_EQ(values[0], iter.first);
     EXPECT_EQ(values[1], iter.second);
   }
   unlink(path);
+
+  std::map<std::string, std::string> immutable_cases = {
+      {"daemonize", "yes"},
+      {"bind", "0.0.0.0"},
+      {"repl-bind", "0.0.0.0"},
+      {"workers", "8"},
+      {"repl-workers", "8"},
+      {"tcp-backlog", "500"},
+      {"codis-enabled", "yes"},
+      {"slaveof", "no one"},
+      {"db-name", "test_dbname"},
+      {"dir", "test_dir"},
+      {"backup-dir", "test_dir/backup"},
+      {"pidfile", "test.pid"},
+      {"supervised", "no"},
+      {"rocksdb.block_size", "1234"},
+      {"rocksdb.target_file_size_base", "100"},
+      {"rocksdb.max_background_flushes", "16"},
+      {"rocksdb.wal_ttl_seconds", "10000"},
+      {"rocksdb.wal_size_limit_mb", "16"},
+      {"rocksdb.enable_pipelined_write", "no"},
+      {"rocksdb.cache_index_and_filter_blocks", "no"},
+      {"rocksdb.metadata_block_cache_size", "100"},
+      {"rocksdb.subkey_block_cache_size", "100"},
+  };
+  for (const auto &iter : immutable_cases) {
+    auto s = config.Set(nullptr, iter.first, iter.second);
+    ASSERT_FALSE(s.IsOK());
+  }
 }
 
 TEST(Namespace, Add) {