[KYUUBI] Fix wrong parameter binding order in JDBCMetadataStore#transformMetadataState

The SQL placeholders expect (targetState, identifier, fromState) but
the code passed (fromState, identifier, targetState), causing the
UPDATE to set state back to fromState and match on targetState instead.
This made cancelUnscheduledBatch silently fail.

Author: wangzhigang1999

kyuubi-server/src/main/scala/org/apache/kyuubi/server/metadata/jdbc/JDBCMetadataStore.scala

@@ -235,7 +235,7 @@ class JDBCMetadataStore(conf: KyuubiConf) extends MetadataStore with Logging {
       targetState: String): Boolean = {
     val query = s"UPDATE $METADATA_TABLE SET state = ? WHERE identifier = ? AND state = ?"
     JdbcUtils.withConnection { connection =>
-      withUpdateCount(connection, query, fromState, identifier, targetState) { updateCount =>
+      withUpdateCount(connection, query, targetState, identifier, fromState) { updateCount =>
         updateCount == 1
       }
     }

kyuubi-server/src/test/scala/org/apache/kyuubi/server/metadata/jdbc/JDBCMetadataStoreSuite.scala

@@ -248,6 +248,32 @@ class JDBCMetadataStoreSuite extends KyuubiFunSuite {
     }
   }
 
+  test("transformMetadataState should transition state correctly") {
+    val batchId = UUID.randomUUID().toString
+    val batchMetadata = Metadata(
+      identifier = batchId,
+      sessionType = SessionType.BATCH,
+      realUser = "kyuubi",
+      username = "kyuubi",
+      ipAddress = "127.0.0.1",
+      state = "INITIALIZED",
+      resource = "intern",
+      className = "org.apache.kyuubi.SparkWC",
+      requestName = "test_transform",
+      createTime = System.currentTimeMillis(),
+      engineType = "SPARK")
+
+    jdbcMetadataStore.insertMetadata(batchMetadata)
+
+    val result = jdbcMetadataStore.transformMetadataState(batchId, "INITIALIZED", "CANCELED")
+    assert(result, "should successfully transition from INITIALIZED to CANCELED")
+
+    val metadata = jdbcMetadataStore.getMetadata(batchId)
+    assert(metadata.state == "CANCELED", s"state should be CANCELED but was ${metadata.state}")
+
+    jdbcMetadataStore.cleanupMetadataByIdentifier(batchId)
+  }
+
   test("throw exception if update count is 0") {
     val metadata = Metadata(identifier = UUID.randomUUID().toString, state = "RUNNING")
     intercept[KyuubiException] {