Add description in openstack and delete unused reboot param

Author: micafer

libcloud/compute/drivers/openstack.py

@@ -1106,7 +1106,7 @@ def _to_absolute(el):
 
         return {"rate": rate, "absolute": absolute}
 
-    def create_image(self, node, name, description=None, reboot=True):
+    def create_image(self, node, name, description=None):
         """Create an image for node.
 
         @inherits: :class:`NodeDriver.create_image`
@@ -1802,14 +1802,22 @@ def create_image(
         :param      name: The name for the new image.
         :type       name: ``str``
 
+        :param      description: A description for the new image. Stored in the
+                                image metadata because the Compute API does not
+                                provide a dedicated description field.
+        :type       description: ``str``
+
         :param      metadata: Key and value pairs for metadata.
         :type       metadata: ``dict``
 
         :rtype: :class:`NodeImage`
         """
         optional_params = {}
-        if metadata:
-            optional_params["metadata"] = metadata
+        image_metadata = dict(metadata) if metadata else {}
+        if description is not None:
+            image_metadata["description"] = description
+        if image_metadata:
+            optional_params["metadata"] = image_metadata
         resp = self._node_action(node, "createImage", name=name, **optional_params)
         image_id = self._extract_image_id_from_url(resp.headers["location"])
         return self.get_image(image_id=image_id)

libcloud/test/compute/test_openstack.py

@@ -1376,6 +1376,33 @@ def test_create_image(self):
         self.assertEqual(image.name, "new_image")
         self.assertEqual(image.id, "4949f9ee-2421-4c81-8b49-13119446008b")
 
+    def test_create_image_with_description_and_metadata(self):
+        metadata = {"version": "1.0"}
+        response = Mock(
+            headers={
+                "location": (
+                    "http://127.0.0.1/v1.1/68/images/"
+                    "4949f9ee-2421-4c81-8b49-13119446008b"
+                )
+            }
+        )
+
+        with mock.patch.object(self.driver, "_node_action", return_value=response) as action:
+            self.driver.create_image(
+                self.node,
+                "new_image",
+                description="Image description",
+                metadata=metadata,
+            )
+
+        action.assert_called_once_with(
+            self.node,
+            "createImage",
+            name="new_image",
+            metadata={"version": "1.0", "description": "Image description"},
+        )
+        self.assertEqual(metadata, {"version": "1.0"})
+
     def test_ex_set_server_name(self):
         old_node = Node(
             id="12064",