Skip to content

Fix Sponsors buttons #3616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 16, 2025
Merged

Fix Sponsors buttons #3616

merged 2 commits into from
Apr 16, 2025

Conversation

ppkarwasz
Copy link
Contributor

Due to limitations in the number of GitHub Sponsors buttons (there can be only up to 4 buttons), part of the team is ignored.

This replaces the buttons with our "Sponsorship" page and a button to sponsor log4j-core via Tidelift.
The end result can be seen on my fork.

Due to limitations in the number of GitHub Sponsors buttons (there can be only up to 4 buttons), part of the team is ignored.

This replaces the buttons with our "Sponsorship" page and a button to sponsor `log4j-core` via Tidelift.
Copy link
Member

@vy vy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ppkarwasz, thanks so much for quickly handling this.

Shall we also add a warning in comments on why one should not add a github element?

@ppkarwasz
Copy link
Contributor Author

Shall we also add a warning in comments on why one should not add a github element?

Done in e310e62.

I'll wait for the checks to succeed and I'll merge this. In the future we'll be able to instruct GitHub to wait for the checks and merge the PR right after (see apache/infrastructure-asfyaml#66).

@ppkarwasz ppkarwasz merged commit 34ced7c into 2.x Apr 16, 2025
11 checks passed
@ppkarwasz ppkarwasz deleted the fix/sponsors-button-2 branch April 16, 2025 09:59
@github-project-automation github-project-automation bot moved this from In review to Done in Log4j bug tracker Apr 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants