Reuse packedTerms between two TermInSetQuery what combined with IndexOrDocValuesQuery

[mkhludnev]

Description

In cases like these

new IndexOrDocValuesQuery(
           new TermInSetQuery(MultiTermQuery.CONSTANT_SCORE_BLENDED_REWRITE, name(), iBytesRefs), 
           new TermInSetQuery(MultiTermQuery.DOC_VALUES_REWRITE, name(), dVByteRefs));

I would like to reuse packedTerms between TermInSetQuery instances. What's the best approach to do it? Or it isn't worthwhile?

[jpountz]

Indeed it would be nice if KeywordField#newSetQuery didn't pay the CPU and heap price for creating the PrefixCodecTerms instance twice. At the same time, let's keep PrefixCodedTerms an implementation-detail that users don't have to deal with?

[mkhludnev]

Presumably, one TermInSetQuery may create another with the rewrite method specified. WDYT?
Or TermInSetQueryBuider may create query by query with different rewrites?

[jpountz]

The builder approach should work. Or maybe a static helper like public static Query newIndexOrDocValuesSetQuery(RewriteMethod indexRewriteMethod, String field, Collection<BytesRef> terms) that could take advantage of the private constructor since this is only a problem for creating an IndexOrDocValuesQuery.