Should we enable the check CheckedExceptionNotThrown in error prone?

[iverase]

This check prevents methods that do not throw a specific exception to declare they do. I think this would be beneficial for Lucene as many method implementation declare they throw IOExceptions when they do not perform any IO making consumer of those methods to have to handle this exceptions when they shouldn't.

Change is trivial but it touches many files.

[dweiss]

This is subtle - when it's public API (an interface, public class) I can envision that the designer anticipated subclasses/ implementations outside of Lucene to possibly throw IOException when none of the implementations within Lucene do throw it... I'd lean towards a case-by-case patches than one single blanket change here.

[msokolov]

agree, for example in a case where most implementations of some interface throw but some do not (like Readers where there is no value), we might want to allow extending classes to throw.