Replace LinkedDictionary with OrderedDictionary

Replaced all usages of JCG.LinkedDictionary with JCG.OrderedDictionary across the codebase for consistency and to better match the semantics of LinkedHashMap in the JDK. Updated comments to clarify the change as Lucene.NET specific.

Author: ksanjeev284

src/Lucene.Net.Analysis.Common/Analysis/Hunspell/Dictionary.cs

@@ -290,7 +290,8 @@ private void ReadAffixFile(Stream affixStream, Encoding decoder)
             patterns.Add(null);
 
             // zero strip -> 0 ord
-            IDictionary<string, int> seenStrips = new JCG.LinkedDictionary<string, int>
+            // LUCENENET specific: OrderedDictioary<TKey, TValue> is a replacement for LinkedHashMap<K, V> in the JDK
+            IDictionary<string, int> seenStrips = new JCG.OrderedDictionary<string, int>
             {
                 [""] = 0
             };

src/Lucene.Net.Analysis.Common/Analysis/Miscellaneous/PerFieldAnalyzerWrapper.cs

@@ -85,7 +85,7 @@ public PerFieldAnalyzerWrapper(Analyzer defaultAnalyzer)
         ///         <description>Use when sorted keys are required. <c>null</c> keys are supported.</description>
         ///     </item>
         ///     <item>
-        ///         <term><see cref="JCG.LinkedDictionary{TKey, TValue}"/></term>
+        ///         <term><see cref="JCG.OrderedDictionary{TKey, TValue}"/></term>
         ///         <description>Use when insertion order must be preserved (<see cref="Dictionary{TKey, TValue}"/> preserves insertion
         ///             order only until items are removed). <c>null</c> keys are supported.</description>
         ///     </item>

src/Lucene.Net.Analysis.Common/Analysis/Util/AnalysisSPILoader.cs

@@ -63,7 +63,8 @@ public void Reload()
             UninterruptableMonitor.Enter(this);
             try
             {
-                IDictionary<string, Type> services = new JCG.LinkedDictionary<string, Type>(this.services);
+                // LUCENENET specific: OrderedDictioary<TKey, TValue> is a replacement for LinkedHashMap<K, V> in the JDK
+                IDictionary<string, Type> services = new JCG.OrderedDictionary<string, Type>(this.services);
                 SPIClassIterator<S> loader = SPIClassIterator<S>.Get();
 
                 foreach (var service in loader)

src/Lucene.Net.Benchmark/ByTask/Tasks/RepSumByNameRoundTask.cs

@@ -55,7 +55,8 @@ public override int DoLogic()
         protected virtual Report ReportSumByNameRound(IList<TaskStats> taskStats)
         {
             // aggregate by task name and round
-            JCG.LinkedDictionary<string, TaskStats> p2 = new JCG.LinkedDictionary<string, TaskStats>();
+            // LUCENENET specific: OrderedDictioary<TKey, TValue> is a replacement for LinkedHashMap<K, V> in the JDK
+            JCG.OrderedDictionary<string, TaskStats> p2 = new JCG.OrderedDictionary<string, TaskStats>();
             int reported = 0;
             foreach (TaskStats stat1 in taskStats)
             {

src/Lucene.Net.Benchmark/ByTask/Tasks/RepSumByNameTask.cs

@@ -56,7 +56,8 @@ protected virtual Report ReportSumByName(IList<TaskStats> taskStats)
         {
             // aggregate by task name
             int reported = 0;
-            JCG.LinkedDictionary<string, TaskStats> p2 = new JCG.LinkedDictionary<string, TaskStats>();
+            // LUCENENET specific: OrderedDictioary<TKey, TValue> is a replacement for LinkedHashMap<K, V> in the JDK
+            JCG.OrderedDictionary<string, TaskStats> p2 = new JCG.OrderedDictionary<string, TaskStats>();
             foreach (TaskStats stat1 in taskStats)
             {
                 if (stat1.Elapsed >= 0)

src/Lucene.Net.Benchmark/ByTask/Tasks/RepSumByPrefRoundTask.cs

@@ -51,7 +51,8 @@ protected virtual Report ReportSumByPrefixRound(IList<TaskStats> taskStats)
         {
             // aggregate by task name and by round
             int reported = 0;
-            JCG.LinkedDictionary<string, TaskStats> p2 = new JCG.LinkedDictionary<string, TaskStats>();
+            // LUCENENET specific: OrderedDictioary<TKey, TValue> is a replacement for LinkedHashMap<K, V> in the JDK
+            JCG.OrderedDictionary<string, TaskStats> p2 = new JCG.OrderedDictionary<string, TaskStats>();
             foreach (TaskStats stat1 in taskStats)
             {
                 if (stat1.Elapsed >= 0 && stat1.Task.GetName().StartsWith(m_prefix, StringComparison.Ordinal))

src/Lucene.Net.Benchmark/ByTask/Tasks/RepSumByPrefTask.cs

@@ -53,7 +53,8 @@ protected virtual Report ReportSumByPrefix(IList<TaskStats> taskStats)
         {
             // aggregate by task name
             int reported = 0;
-            JCG.LinkedDictionary<string, TaskStats> p2 = new JCG.LinkedDictionary<string, TaskStats>();
+            // LUCENENET specific: OrderedDictioary<TKey, TValue> is a replacement for LinkedHashMap<K, V> in the JDK
+            JCG.OrderedDictionary<string, TaskStats> p2 = new JCG.OrderedDictionary<string, TaskStats>();
             foreach (TaskStats stat1 in taskStats)
             {
                 if (stat1.Elapsed >= 0 && stat1.Task.GetName().StartsWith(m_prefix, StringComparison.Ordinal))

src/Lucene.Net.Benchmark/ByTask/Tasks/ReportTask.cs

@@ -130,7 +130,8 @@ protected virtual string TaskReportLine(string longestOp, TaskStats stat)
             return sb.ToString();
         }
 
-        protected virtual Report GenPartialReport(int reported, JCG.LinkedDictionary<string, TaskStats> partOfTasks, int totalSize)
+        // LUCENENET specific: OrderedDictioary<TKey, TValue> is a replacement for LinkedHashMap<K, V> in the JDK
+        protected virtual Report GenPartialReport(int reported, JCG.OrderedDictionary<string, TaskStats> partOfTasks, int totalSize)
         {
             string longetOp = LongestOp(partOfTasks.Values);
             bool first = true;

src/Lucene.Net.Expressions/JS/JavascriptCompiler.cs

@@ -89,7 +89,8 @@ private static MethodInfo GetMethod(Type type, string method, Type[] parms)
 
         private readonly string sourceText;
 
-        private readonly IDictionary<string, int> externalsMap = new JCG.LinkedDictionary<string, int>();
+        // LUCENENET specific: OrderedDictioary<TKey, TValue> is a replacement for LinkedHashMap<K, V> in the JDK
+        private readonly IDictionary<string, int> externalsMap = new JCG.OrderedDictionary<string, int>();
 
         private TypeBuilder dynamicType;
 

src/Lucene.Net.Facet/DrillDownQuery.cs

@@ -76,7 +76,8 @@ public static Term Term(string field, string dim, params string[] path)
 
         private readonly FacetsConfig config;
         private readonly BooleanQuery query;
-        private readonly IDictionary<string, int> drillDownDims = new JCG.LinkedDictionary<string, int>();
+        // LUCENENET specific: OrderedDictioary<TKey, TValue> is a replacement for LinkedHashMap<K, V> in the JDK
+        private readonly IDictionary<string, int> drillDownDims = new JCG.OrderedDictionary<string, int>();
 
         /// <summary>
         /// Used by <see cref="Clone"/>