Add comments about FileShare modes

Author: paulirwin

src/Lucene.Net/Store/MMapDirectory.cs

@@ -896,7 +896,9 @@ private static SharedMapping CreateAttempt(string file, int chunkSizePower)
                 // immediately recursively delete the directory. We need
                 // FileShare.Delete in particular: on Windows, a delete
                 // attempt against an open file fails unless the open
-                // share-mode permits FILE_SHARE_DELETE.
+                // share-mode permits FILE_SHARE_DELETE. In Java, FileChannel
+                // uses read+write+delete mode by default and Lucene doesn't
+                // override this.
                 //
                 // bufferSize: 1 because MemoryMappedFile uses only the
                 // file handle and bypasses the FileStream buffer, so a

src/Lucene.Net/Store/NIOFSDirectory.cs

@@ -103,6 +103,8 @@ public override IndexInput OpenInput(string name, IOContext context)
         {
             EnsureOpen();
             var path = Path.Combine(Directory.FullName, name); // LUCENENET specific: changed to use string file name instead of allocating a FileInfo (#832)
+            // LUCENENET NOTE: FileShare Read+Write+Delete is correct and matches Java Lucene.
+            // In Java, FileChannel defaults to this behavior, and Lucene does not override it.
             var fc = new FileStream(path, FileMode.Open, FileAccess.Read, FileShare.ReadWrite | FileShare.Delete);
             return new NIOFSIndexInput("NIOFSIndexInput(path=\"" + path + "\")", fc, context);
         }
@@ -111,6 +113,8 @@ public override IndexInputSlicer CreateSlicer(string name, IOContext context)
         {
             EnsureOpen();
             var path = Path.Combine(Directory.FullName, name); // LUCENENET specific: changed to use string file name instead of allocating a FileInfo (#832)
+            // LUCENENET NOTE: FileShare Read+Write+Delete is correct and matches Java Lucene.
+            // In Java, FileChannel defaults to this behavior, and Lucene does not override it.
             var fc = new FileStream(path, FileMode.Open, FileAccess.Read, FileShare.ReadWrite | FileShare.Delete);
             return new IndexInputSlicerAnonymousClass(context, path, fc);
         }

src/Lucene.Net/Store/SimpleFSDirectory.cs

@@ -100,6 +100,9 @@ public override IndexInput OpenInput(string name, IOContext context)
         {
             EnsureOpen();
             var path = Path.Combine(Directory.FullName, name); // LUCENENET specific: changed to use string file name instead of allocating a FileInfo (#832)
+            // LUCENENET NOTE: FileShare Read+Write matches Java Lucene.
+            // In Java, RandomAccessFile defaults to this behavior.
+            // LUCENENET TODO: Determine if we should add Delete as well. See issue #1283
             var raf = new FileStream(path, FileMode.Open, FileAccess.Read, FileShare.ReadWrite);
             return new SimpleFSIndexInput("SimpleFSIndexInput(path=\"" + path + "\")", raf, context);
         }
@@ -108,6 +111,9 @@ public override IndexInputSlicer CreateSlicer(string name, IOContext context)
         {
             EnsureOpen();
             var file = Path.Combine(Directory.FullName, name); // LUCENENET specific: changed to use string file name instead of allocating a FileInfo (#832)
+            // LUCENENET NOTE: FileShare Read+Write matches Java Lucene.
+            // In Java, RandomAccessFile defaults to this behavior.
+            // LUCENENET TODO: Determine if we should add Delete as well. See issue #1283
             var descriptor = new FileStream(file, FileMode.Open, FileAccess.Read, FileShare.ReadWrite);
             return new IndexInputSlicerAnonymousClass(context, file, descriptor);
         }