Added Lucene.Net.CodeAnalysis.Dev package reference (#1190)

* Directory.Build.targets: Added global reference to Lucene.Net.CodeAnalysis.Dev to enable development analyzers

* SWEEP: Fixed LuceneDev1001 build warnings

Author: NightOwl888

.build/dependencies.props

@@ -40,6 +40,7 @@
     <!-- J2N will break binary compatibility in 3.0.0 to fix the APIs of collection types -->
     <J2NPackageVersion>[2.2.0-alpha-0021, 3.0.0)</J2NPackageVersion>
     <LiquidTestReportsMarkdownPackageVersion>1.0.9</LiquidTestReportsMarkdownPackageVersion>
+    <LuceneNetCodeAnalysisDevPackageVersion>1.0.0-alpha.6</LuceneNetCodeAnalysisDevPackageVersion>
     <MicrosoftAspNetCoreHttpAbstractionsPackageVersion>2.3.0</MicrosoftAspNetCoreHttpAbstractionsPackageVersion>
     <MicrosoftAspNetCoreTestHostPackageVersion>8.0.19</MicrosoftAspNetCoreTestHostPackageVersion>
     <MicrosoftCodeAnalysisAnalyzersPackageVersion>2.9.8</MicrosoftCodeAnalysisAnalyzersPackageVersion>

Directory.Build.targets

@@ -24,6 +24,12 @@
 
   <PropertyGroup Label="Warnings to be Disabled in Solution">
     <NoWarn Label="Legacy serialization support APIs are obsolete">$(NoWarn);SYSLIB0051</NoWarn>
+
+    <!-- These are noisy, but may be helpful during Lucene upgrades or optimization -->
+    <NoWarn Label="Floating point types should not be compared for exact equality">$(NoWarn);LuceneDev1000</NoWarn>
+    <NoWarn Label="Floating point type arithmetic needs to be checked on x86 in .NET Framework and may require extra casting">$(NoWarn);LuceneDev1002</NoWarn>
+    <NoWarn Label="Java array parameters can sometimes be replaced with .NET out or ref parameters">$(NoWarn);LuceneDev1003</NoWarn>
+    <NoWarn Label="Return array may be able to be replaced with out values">$(NoWarn);LuceneDev1004</NoWarn>
   </PropertyGroup>
 
   <PropertyGroup Label="Solution-level Publish to Project-specific Directory">
@@ -222,6 +228,10 @@
     <PackageReference Include="Microsoft.SourceLink.GitHub" Version="$(MicrosoftSourceLinkGitHubPackageReferenceVersion)" PrivateAssets="All"/>
   </ItemGroup>
 
+  <ItemGroup>
+    <PackageReference Include="Lucene.Net.CodeAnalysis.Dev" Version="$(LuceneNetCodeAnalysisDevPackageVersion)" PrivateAssets="All" />
+  </ItemGroup>
+
   <Import Project=".build/release.targets" Condition="Exists('.build/release.targets')" />
 
 </Project>

src/Lucene.Net.Benchmark/ByTask/Tasks/AnalyzerFactoryTask.cs

@@ -155,7 +155,7 @@ public override void SetParams(string @params)
                                     {
                                         case StreamTokenizer.TokenType_Number:
                                             {
-                                                argValue = stok.NumberValue.ToString(CultureInfo.InvariantCulture);
+                                                argValue = J2N.Numerics.Double.ToString(stok.NumberValue, CultureInfo.InvariantCulture);
                                                 // Drop the ".0" from numbers, for integer arguments
                                                 argValue = TRAILING_DOT_ZERO_PATTERN.Replace(argValue, "", 1);
                                                 // Intentional fallthrough
@@ -440,7 +440,7 @@ private void CreateAnalysisPipelineComponent(StreamTokenizer stok, Type clazz)
                                 {
                                     case StreamTokenizer.TokenType_Number:
                                         {
-                                            argValue = stok.NumberValue.ToString(CultureInfo.InvariantCulture);
+                                            argValue = J2N.Numerics.Double.ToString(stok.NumberValue, CultureInfo.InvariantCulture);
                                             // Drop the ".0" from numbers, for integer arguments
                                             argValue = TRAILING_DOT_ZERO_PATTERN.Replace(argValue, "", 1);
                                             // Intentional fall-through

src/Lucene.Net.Benchmark/ByTask/Utils/Algorithm.cs

@@ -116,7 +116,7 @@ public Algorithm(PerfRunData runData)
                                     {
                                         case StreamTokenizer.TokenType_Number:
                                             {
-                                                @params.Append(stok.NumberValue.ToString(CultureInfo.InvariantCulture));
+                                                @params.Append(J2N.Numerics.Double.ToString(stok.NumberValue, CultureInfo.InvariantCulture));
                                                 break;
                                             }
                                         case StreamTokenizer.TokenType_Word:

src/Lucene.Net.Benchmark/ByTask/Utils/Config.cs

@@ -269,7 +269,7 @@ public virtual double Get(string name, double dflt)
             // done if not by round
             if (!props.TryGetValue(name, out string sval))
             {
-                sval = dflt.ToString(CultureInfo.InvariantCulture);
+                sval = J2N.Numerics.Double.ToString(dflt, CultureInfo.InvariantCulture);
             }
             if (sval.IndexOf(':') < 0)
             {

src/Lucene.Net.QueryParser/Flexible/Core/Nodes/BoostQueryNode.cs

@@ -83,7 +83,7 @@ private string GetValueString()
             if (f == (long)f)
                 return "" + (long)f;
             else
-                return "" + f.ToString("0.0#######"); // LUCENENET TODO: Culture
+                return "" + J2N.Numerics.Single.ToString(f, "0.0#######"); // LUCENENET TODO: Culture
         }
 
         public override string ToString()

src/Lucene.Net/Index/CheckIndex.cs

@@ -717,7 +717,7 @@ public virtual Status DoCheckIndex(IList<string> onlySegments)
 #pragma warning restore 612, 618
                     {
                         // don't print size in bytes if its a 3.0 segment with shared docstores
-                        Msg(infoStream, "    size (MB)=" + segInfoStat.SizeMB.ToString(nf));
+                        Msg(infoStream, "    size (MB)=" + J2N.Numerics.Double.ToString(segInfoStat.SizeMB, nf));
                     }
                     IDictionary<string, string> diagnostics = info.Info.Diagnostics;
                     segInfoStat.Diagnostics = diagnostics;
@@ -2269,7 +2269,7 @@ public static Status.TermVectorStatus TestTermVectors(AtomicReader reader, TextW
                     }
                 }
                 float vectorAvg = status.DocCount == 0 ? 0 : status.TotVectors / (float)status.DocCount;
-                Msg(infoStream, "OK [" + status.TotVectors + " total vector count; avg " + vectorAvg.ToString(CultureInfo.InvariantCulture.NumberFormat) + " term/freq vector fields per doc]");
+                Msg(infoStream, "OK [" + status.TotVectors + " total vector count; avg " + J2N.Numerics.Single.ToString(vectorAvg, NumberFormatInfo.InvariantInfo) + " term/freq vector fields per doc]");
             }
             catch (Exception e) when (e.IsThrowable())
             {

src/Lucene.Net/Index/DocumentsWriterPerThread.cs

@@ -571,7 +571,7 @@ internal virtual FlushedSegment Flush()
                 if (infoStream.IsEnabled("DWPT"))
                 {
                     double newSegmentSize = segmentInfoPerCommit.GetSizeInBytes() / 1024.0 / 1024.0;
-                    infoStream.Message("DWPT", "flushed: segment=" + segmentInfo.Name + " ramUsed=" + startMBUsed.ToString(nf) + " MB" + " newFlushedSize(includes docstores)=" + newSegmentSize.ToString(nf) + " MB" + " docs/MB=" + (flushState.SegmentInfo.DocCount / newSegmentSize).ToString(nf));
+                    infoStream.Message("DWPT", "flushed: segment=" + segmentInfo.Name + " ramUsed=" + J2N.Numerics.Double.ToString(startMBUsed, nf) + " MB" + " newFlushedSize(includes docstores)=" + J2N.Numerics.Double.ToString(newSegmentSize, nf) + " MB" + " docs/MB=" + J2N.Numerics.Double.ToString((flushState.SegmentInfo.DocCount / newSegmentSize), nf));
                 }
 
                 if (Debugging.AssertsEnabled) Debugging.Assert(segmentInfo != null);

src/Lucene.Net/Index/LogMergePolicy.cs

@@ -660,7 +660,7 @@ public override MergeSpecification FindMerges(MergeTrigger mergeTrigger, Segment
                 }
                 if (IsVerbose)
                 {
-                    Message("  level " + levelBottom.ToString("0.0") + " to " + maxLevel.ToString("0.0") + ": " + (1 + upto - start) + " segments");
+                    Message("  level " + J2N.Numerics.Single.ToString(levelBottom) + " to " + J2N.Numerics.Single.ToString(maxLevel) + ": " + (1 + upto - start) + " segments");
                 }
 
                 // Finally, record all merges that are viable at this level:

src/Lucene.Net/Index/TieredMergePolicy.cs

@@ -152,7 +152,7 @@ public virtual double MaxMergedSegmentMB
             {
                 if (value < 0.0)
                 {
-                    throw new ArgumentOutOfRangeException(nameof(MaxMergedSegmentMB), "maxMergedSegmentMB must be >=0 (got " + value.ToString("0.0") + ")"); // LUCENENET specific - changed from IllegalArgumentException to ArgumentOutOfRangeException (.NET convention)
+                    throw new ArgumentOutOfRangeException(nameof(MaxMergedSegmentMB), "maxMergedSegmentMB must be >=0 (got " + J2N.Numerics.Double.ToString(value) + ")"); // LUCENENET specific - changed from IllegalArgumentException to ArgumentOutOfRangeException (.NET convention)
                 }
                 value *= 1024 * 1024;
                 maxMergedSegmentBytes = (value > long.MaxValue) ? long.MaxValue : (long)value;
@@ -175,7 +175,7 @@ public virtual double ReclaimDeletesWeight
             {
                 if (value < 0.0)
                 {
-                    throw new ArgumentOutOfRangeException(nameof(ReclaimDeletesWeight), "reclaimDeletesWeight must be >= 0.0 (got " + value.ToString("0.0") + ")"); // LUCENENET specific - changed from IllegalArgumentException to ArgumentOutOfRangeException (.NET convention)
+                    throw new ArgumentOutOfRangeException(nameof(ReclaimDeletesWeight), "reclaimDeletesWeight must be >= 0.0 (got " + J2N.Numerics.Double.ToString(value) + ")"); // LUCENENET specific - changed from IllegalArgumentException to ArgumentOutOfRangeException (.NET convention)
                 }
                 reclaimDeletesWeight = value;
             }
@@ -195,7 +195,7 @@ public virtual double FloorSegmentMB
             {
                 if (value <= 0.0)
                 {
-                    throw new ArgumentOutOfRangeException(nameof(FloorSegmentMB), "floorSegmentMB must be >= 0.0 (got " + value.ToString("0.0") + ")"); // LUCENENET specific - changed from IllegalArgumentException to ArgumentOutOfRangeException (.NET convention)
+                    throw new ArgumentOutOfRangeException(nameof(FloorSegmentMB), "floorSegmentMB must be >= 0.0 (got " + J2N.Numerics.Double.ToString(value) + ")"); // LUCENENET specific - changed from IllegalArgumentException to ArgumentOutOfRangeException (.NET convention)
                 }
                 value *= 1024 * 1024;
                 floorSegmentBytes = (value > long.MaxValue) ? long.MaxValue : (long)value;
@@ -214,7 +214,7 @@ public virtual double ForceMergeDeletesPctAllowed
             {
                 if (value < 0.0 || value > 100.0)
                 {
-                    throw new ArgumentOutOfRangeException(nameof(ForceMergeDeletesPctAllowed), "forceMergeDeletesPctAllowed must be between 0.0 and 100.0 inclusive (got " + value.ToString("0.0") + ")"); // LUCENENET specific - changed from IllegalArgumentException to ArgumentOutOfRangeException (.NET convention)
+                    throw new ArgumentOutOfRangeException(nameof(ForceMergeDeletesPctAllowed), "forceMergeDeletesPctAllowed must be between 0.0 and 100.0 inclusive (got " + J2N.Numerics.Double.ToString(value) + ")"); // LUCENENET specific - changed from IllegalArgumentException to ArgumentOutOfRangeException (.NET convention)
                 }
                 forceMergeDeletesPctAllowed = value;
             }
@@ -237,7 +237,7 @@ public virtual double SegmentsPerTier
             {
                 if (value < 2.0)
                 {
-                    throw new ArgumentOutOfRangeException(nameof(SegmentsPerTier), "segmentsPerTier must be >= 2.0 (got " + value.ToString("0.0") + ")"); // LUCENENET specific - changed from IllegalArgumentException to ArgumentOutOfRangeException (.NET convention)
+                    throw new ArgumentOutOfRangeException(nameof(SegmentsPerTier), "segmentsPerTier must be >= 2.0 (got " + J2N.Numerics.Double.ToString(value) + ")"); // LUCENENET specific - changed from IllegalArgumentException to ArgumentOutOfRangeException (.NET convention)
                 }
                 segsPerTier = value;
             }