Use LangVersion 14 and fix field warnings/errors

Author: paulirwin

Directory.Build.props

@@ -26,7 +26,7 @@
   </PropertyGroup>
 
   <PropertyGroup>
-    <LangVersion>11.0</LangVersion>
+    <LangVersion>14.0</LangVersion>
     <GitHubOrganization>apache</GitHubOrganization>
     <GitHubProject>lucenenet</GitHubProject>
   </PropertyGroup>

src/Lucene.Net.Codecs/Memory/DirectPostingsFormat.cs

@@ -163,9 +163,9 @@ public override long UniqueTermCount
                 get
                 {
                     long numTerms = 0;
-                    foreach (DirectField field in fields.Values)
+                    foreach (DirectField f in fields.Values)
                     {
-                        numTerms += field.terms.Length;
+                        numTerms += f.terms.Length;
                     }
                     return numTerms;
                 }

src/Lucene.Net.Codecs/Memory/MemoryPostingsFormat.cs

@@ -931,13 +931,13 @@ public override TermsEnum GetEnumerator()
             public override IComparer<BytesRef> Comparer => BytesRef.UTF8SortedAsUnicodeComparer;
 
             // LUCENENET specific - to avoid boxing, changed from CompareTo() to IndexOptionsComparer.Compare()
-            public override bool HasFreqs => IndexOptionsComparer.Default.Compare(field.IndexOptions, IndexOptions.DOCS_AND_FREQS) >= 0;
+            public override bool HasFreqs => IndexOptionsComparer.Default.Compare(this.field.IndexOptions, IndexOptions.DOCS_AND_FREQS) >= 0;
 
-            public override bool HasOffsets => IndexOptionsComparer.Default.Compare(field.IndexOptions, IndexOptions.DOCS_AND_FREQS_AND_POSITIONS_AND_OFFSETS) >= 0;
+            public override bool HasOffsets => IndexOptionsComparer.Default.Compare(this.field.IndexOptions, IndexOptions.DOCS_AND_FREQS_AND_POSITIONS_AND_OFFSETS) >= 0;
 
-            public override bool HasPositions => IndexOptionsComparer.Default.Compare(field.IndexOptions, IndexOptions.DOCS_AND_FREQS_AND_POSITIONS) >= 0;
+            public override bool HasPositions => IndexOptionsComparer.Default.Compare(this.field.IndexOptions, IndexOptions.DOCS_AND_FREQS_AND_POSITIONS) >= 0;
 
-            public override bool HasPayloads => field.HasPayloads;
+            public override bool HasPayloads => this.field.HasPayloads;
 
             public long RamBytesUsed()
             {

src/Lucene.Net.Facet/SortedSet/DefaultSortedSetDocValuesReaderState.cs

@@ -125,7 +125,7 @@ public override OrdRange GetOrdRange(string dim)
         /// <summary>
         /// Indexed field we are reading.
         /// </summary>
-        public override string Field => field;
+        public override string Field => this.field;
 
         public override IndexReader OrigReader => origReader;
 

src/Lucene.Net.Facet/Taxonomy/DocValuesOrdinalsReader.cs

@@ -82,7 +82,7 @@ public override void Get(int docID, Int32sRef ordinals)
             }
         }
 
-        public override string IndexFieldName => field;
+        public override string IndexFieldName => this.field;
 
         /// <summary>
         /// Subclass &amp; override if you change the encoding.

src/Lucene.Net.Queries/Function/ValueSources/ReverseOrdFieldSource.cs

@@ -48,7 +48,7 @@ public class ReverseOrdFieldSource : ValueSource
     {
         // LUCENENET NOTE: Made private and added public property for reading
         private readonly string field;
-        public string Field => field;
+        public string Field => this.field;
 
         public ReverseOrdFieldSource(string field)
         {

src/Lucene.Net.QueryParser/ComplexPhrase/ComplexPhraseQueryParser.cs

@@ -227,7 +227,7 @@ public ComplexPhraseQuery(string field, string phrasedQueryStringContents,
                 this.inOrder = inOrder;
             }
 
-            public string Field => field;
+            public string Field => this.field;
 
             // Called by ComplexPhraseQueryParser for each phrase after the main
             // parse

src/Lucene.Net.QueryParser/Flexible/Standard/Nodes/AbstractRangeQueryNode.cs

@@ -52,21 +52,20 @@ public virtual string Field
         {
             get
             {
-                string field = null;
+                string f = null;
                 T lower = (T)LowerBound;
                 T upper = (T)UpperBound;
 
                 if (lower != null)
                 {
-                    field = lower.Field;
-
+                    f = lower.Field;
                 }
                 else if (upper != null)
                 {
-                    field = upper.Field;
+                    f = upper.Field;
                 }
 
-                return field;
+                return f;
             }
             set
             {

src/Lucene.Net.QueryParser/Flexible/Standard/Nodes/RegexpQueryNode.cs

@@ -99,7 +99,7 @@ public virtual ICharSequence Text
 
         public virtual string Field
         {
-            get => field;
+            get => this.field;
             set => this.field = value;
         }
 

src/Lucene.Net.Tests.Analysis.Kuromoji/Lucene.Net.Tests.Analysis.Kuromoji.csproj

@@ -25,7 +25,6 @@
 
   <PropertyGroup>
     <AssemblyTitle>Lucene.Net.Tests.Analysis.Kuromoji</AssemblyTitle>
-    <LangVersion>14.0</LangVersion>
   </PropertyGroup>
 
   <ItemGroup>