More C# 14 field keyword changes

Author: paulirwin

src/Lucene.Net.Facet/SortedSet/DefaultSortedSetDocValuesReaderState.cs

@@ -29,7 +29,7 @@ namespace Lucene.Net.Facet.SortedSet
     /// </summary>
     public class DefaultSortedSetDocValuesReaderState : SortedSetDocValuesReaderState
     {
-        private readonly string field;
+        private readonly string _field; // LUCENENET: must name as _field in C# 14 since 'field' is now a keyword
         private readonly AtomicReader topReader;
         private readonly int valueCount;
 
@@ -45,7 +45,7 @@ public class DefaultSortedSetDocValuesReaderState : SortedSetDocValuesReaderStat
         /// </summary>
         public DefaultSortedSetDocValuesReaderState(IndexReader reader, string field = FacetsConfig.DEFAULT_INDEX_FIELD_NAME)
         {
-            this.field = field;
+            this._field = field;
             this.origReader = reader;
 
             // We need this to create thread-safe MultiSortedSetDV
@@ -104,7 +104,7 @@ public DefaultSortedSetDocValuesReaderState(IndexReader reader, string field = F
         /// </summary>
         public override SortedSetDocValues GetDocValues()
         {
-            return topReader.GetSortedSetDocValues(field);
+            return topReader.GetSortedSetDocValues(_field);
         }
 
         /// <summary>
@@ -124,7 +124,7 @@ public override OrdRange GetOrdRange(string dim)
         /// <summary>
         /// Indexed field we are reading.
         /// </summary>
-        public override string Field => field;
+        public override string Field => _field;
 
         public override IndexReader OrigReader => origReader;
 

src/Lucene.Net.Facet/Taxonomy/DocValuesOrdinalsReader.cs

@@ -31,7 +31,7 @@ namespace Lucene.Net.Facet.Taxonomy
     /// </summary>
     public class DocValuesOrdinalsReader : OrdinalsReader
     {
-        private readonly string field;
+        private readonly string _field; // LUCENENET: must name as _field in C# 14 since 'field' is now a keyword
 
         /// <summary>
         /// Default constructor.
@@ -46,12 +46,12 @@ public DocValuesOrdinalsReader()
         /// </summary>
         public DocValuesOrdinalsReader(string field)
         {
-            this.field = field;
+            this._field = field;
         }
 
         public override OrdinalsSegmentReader GetReader(AtomicReaderContext context)
         {
-            BinaryDocValues values0 = context.AtomicReader.GetBinaryDocValues(field);
+            BinaryDocValues values0 = context.AtomicReader.GetBinaryDocValues(_field);
             if (values0 is null)
             {
                 values0 = DocValues.EMPTY_BINARY;
@@ -82,7 +82,7 @@ public override void Get(int docID, Int32sRef ordinals)
             }
         }
 
-        public override string IndexFieldName => field;
+        public override string IndexFieldName => _field;
 
         /// <summary>
         /// Subclass &amp; override if you change the encoding.