Apply suggestions from code review

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Author: paulirwin

.github/workflows/Lucene-Net-Index-Compatibility.yml

@@ -31,7 +31,8 @@ on:
     paths:
     # The compatibility harness itself
     - 'src/java/index-compat/**/*'
-    - 'src/Lucene.Net.Tests/Index/TestJavaCompatibility.cs'
+    - 'src/Lucene.Net.Tests/Support/Index/CompatDocs.cs'
+    - 'src/Lucene.Net.Tests/Support/Index/TestJavaCompatibility.cs'
     # Production code whose on-disk format the harness validates
     - 'src/Lucene.Net/Codecs/**/*'
     - 'src/Lucene.Net/Index/**/*'

src/java/index-compat/run-compat.bat

@@ -27,4 +27,4 @@ GOTO endcommentblock
 :: -----------------------------------------------------------------------------------
 :endcommentblock
 where pwsh >nul 2>nul
-if %ERRORLEVEL% NEQ 0 (echo "PowerShell could not be found. Please install version 3 or higher.") else (pwsh -ExecutionPolicy bypass -Command "& '%~dpn0.ps1'" %*)
+if %ERRORLEVEL% NEQ 0 (echo "PowerShell could not be found. Please install version 3 or higher." & exit /b 1) else (pwsh -ExecutionPolicy bypass -Command "& '%~dpn0.ps1'" %*)

src/java/index-compat/src/main/java/org/apache/lucenenet/compat/GenerateIndex.java

@@ -66,8 +66,14 @@ public static void main(String[] args) throws Exception {
     private static void write(Path indexPath, boolean useCompoundFile) throws Exception {
         File dirFile = indexPath.toFile();
         if (dirFile.exists()) {
-            for (File f : dirFile.listFiles()) {
-                f.delete();
+            File[] files = dirFile.listFiles();
+            if (files == null) {
+                throw new IllegalStateException("Index path exists but is not a directory: " + dirFile.getAbsolutePath());
+            }
+            for (File f : files) {
+                if (!f.delete()) {
+                    throw new IllegalStateException("Failed to delete existing file: " + f.getAbsolutePath());
+                }
             }
         } else {
             Files.createDirectories(indexPath);