Enable markdownlint rule MD038/no-space-in-code Spaces inside code span elements

Author: jbampton

.github/linters/.markdown-lint.yml

@@ -93,9 +93,6 @@ MD036: false
 # MD037/no-space-in-emphasis Spaces inside emphasis markers
 MD037: false
 
-# MD038/no-space-in-code Spaces inside code span elements
-MD038: false
-
 # MD039/no-space-in-links Spaces inside link text
 MD039: false
 

websites/site/quick-start/tutorial.md

@@ -47,7 +47,7 @@ We are going to create a console application that uses Lucene.NET to index three
 This is actually pretty simple to do in Lucene.NET but since this in our very first Lucene.NET application we are going to walk through it step by step and provide a lot of explanation along the way.
 
 ### Create a Directory for the Project
-Create a directory where you would like this project to live on your hard drive and call that directory `lucene-example1`. In my case that will be ` C:\Users\Ron\source\repos\lucene-example1` but you can chose any location you like.  Then make that directory the current directory in PowerShell.
+Create a directory where you would like this project to live on your hard drive and call that directory `lucene-example1`. In my case that will be `C:\Users\Ron\source\repos\lucene-example1` but you can chose any location you like.  Then make that directory the current directory in PowerShell.
 
 In my case, since I'm on Windows, I'll create the directory using the GUI and use the `cd` command in PowerShell to change directory to the one I created.  So the exact PowerShell command I used was  `cd C:\Users\Ron\source\repos\lucene-example1` but you will need to modify that command to specify the directory you created.
 
@@ -324,7 +324,7 @@ Create a directory where you would like this project to live, call it `lucene-ex
 
 You can use whatever tool you choose for Example 1 to accomplish these steps. In my case I will created the directory in the GUI then make it the current directory in PowerShell and then execute these commands in PowerShell one at a time (similar to how I did it in Example 1):
 
-` dotnet new console`
+`dotnet new console`
 
 `dotnet add package Lucene.Net --prerelease`
 

websites/site/release-notes/version-4.8.0-beta00014.md

@@ -131,10 +131,10 @@ IterationCount=15  LaunchCount=2  WarmupCount=10
 * [#434](https://github.com/apache/lucenenet/pull/434), [#419](https://github.com/apache/lucenenet/pull/419) - `HunspellStemFilter` does not work with zero affix
 * [#439](https://github.com/apache/lucenenet/pull/439) - `Lucene.Net.Facet.Taxonomy.CachedOrdinalsReader`: Fixed synchronization issue between adding new items to the cache and reading `RamBytesUsed` method
 * [#439](https://github.com/apache/lucenenet/pull/439), [#417](https://github.com/apache/lucenenet/pull/417), [#319](https://github.com/apache/lucenenet/pull/319) -  `Lucene.Net.Spatial.Util.ShapeFieldCacheProvider`: Fixed atomicity issue with loading the cache by using `Lazy<T>`.
-* [#441](https://github.com/apache/lucenenet/pull/441) - ` Lucene.Net.TestFramework.Support.Configuration.TestConfigurationFactory`: Use `Lazy<T>` to ensure the `configurationCache.GetOrAdd()` factory is atomic.
-* [#441](https://github.com/apache/lucenenet/pull/441) - `Lucene.Net.TestFramework.Search.ShardSearchingTestBase: Fixed possible `KeyNotFoundException` when getting the value from `collectionStatisticsCache`
+* [#441](https://github.com/apache/lucenenet/pull/441) - `Lucene.Net.TestFramework.Support.Configuration.TestConfigurationFactory`: Use `Lazy<T>` to ensure the `configurationCache.GetOrAdd()` factory is atomic.
+* [#441](https://github.com/apache/lucenenet/pull/441) - `Lucene.Net.TestFramework.Search.ShardSearchingTestBase`: Fixed possible `KeyNotFoundException` when getting the value from `collectionStatisticsCache`
 * [#441](https://github.com/apache/lucenenet/pull/441), [#417](https://github.com/apache/lucenenet/pull/417), [#319](https://github.com/apache/lucenenet/pull/319) - `Lucene.Net.Spatial.Prefix.PrefixTreeFactory`: Use `Lazy<T>` in `ConcurrentDictionary` to make the `valueFactory` atomic.
-* [#443](https://github.com/apache/lucenenet/pull/443) - `Lucene.Net.Benchmark.ByTask.Feeds.SpatialDocMaker: Since `Dictionary<TKey, TValue>.this[key]` is not marked virtual in .NET, subclassing `Dictionary<string, string>` is not a valid approach. So we implement `IDictionary<string, string>` instead.
+* [#443](https://github.com/apache/lucenenet/pull/443) - `Lucene.Net.Benchmark.ByTask.Feeds.SpatialDocMaker`: Since `Dictionary<TKey, TValue>.this[key]` is not marked virtual in .NET, subclassing `Dictionary<string, string>` is not a valid approach. So we implement `IDictionary<string, string>` instead.
 * [#416](https://github.com/apache/lucenenet/pull/416) - CLI Documentation issue - environment variable token not replaced.
 * [#450](https://github.com/apache/lucenenet/pull/450) - `Lucene.Net.Facet` - Reverted locking in to the state it was in Lucene 4.8.1, however we are still making use of `ReaderWriterLockSlim` to improve read performance of caches. Also, removed the 1 second lock timeout from `Cl2oTaxonomyWriterCache`.
 
@@ -164,12 +164,12 @@ IterationCount=15  LaunchCount=2  WarmupCount=10
 * [#439](https://github.com/apache/lucenenet/pull/439) - `Lucene.Net.Util.AttributeSource`: Restored comment from Lucene indicating it doesn't matter if multiple threads compete to populate the `ConditionalWeakTable`.
 * [#440](https://github.com/apache/lucenenet/pull/440) - **SWEEP**: Reviewed catch blocks and made improvements to preserve stack details.
 * [#441](https://github.com/apache/lucenenet/pull/441), [#417](https://github.com/apache/lucenenet/pull/417) -  `Lucene.Net.Analysis.OpenNLP.Tools.OpenNLPOpsFactory`: Simplified logic by using `GetOrAdd()` instead of `TryGetValue`.
-* [#441](https://github.com/apache/lucenenet/pull/441) - ` Lucene.Net.TestFramework.Util` (`LuceneTestCase` + `TestUtil`): Refactored the `CleanupTemporaryFiles()` method to be more in line with the original Java implementation, including not allowing new files/directories to be added to the queue concurrently with the deletion process.
-* [#441](https://github.com/apache/lucenenet/pull/441) - **PERFORMANCE:** ` Lucene.Net.Join.ToParentBlockJoinCollector`: Changed from `ConcurrentQueue<T>` to `Queue<T>` because we are dealing with a collection declared within the same method so there is no reason for the extra overhead.
-* [#441](https://github.com/apache/lucenenet/pull/441) - **PERFORMANCE:** ` Lucene.Net.Tests.Suggest.Spell.TestSpellChecker`: Replaced `ConcurrentBag<T>` with ConcurrentQueue<T> because we need to be sure the underlying implementation guarantees order and the extra call to `Reverse()` was just slowing things down.
-* [#441](https://github.com/apache/lucenenet/pull/441) - ` Lucene.Net.TestFramework.Search.ShardSearchingTestBase`: Display the contents of the collection to the console using `Collections.ToString()`.
+* [#441](https://github.com/apache/lucenenet/pull/441) - `Lucene.Net.TestFramework.Util` (`LuceneTestCase` + `TestUtil`): Refactored the `CleanupTemporaryFiles()` method to be more in line with the original Java implementation, including not allowing new files/directories to be added to the queue concurrently with the deletion process.
+* [#441](https://github.com/apache/lucenenet/pull/441) - **PERFORMANCE:** `Lucene.Net.Join.ToParentBlockJoinCollector`: Changed from `ConcurrentQueue<T>` to `Queue<T>` because we are dealing with a collection declared within the same method so there is no reason for the extra overhead.
+* [#441](https://github.com/apache/lucenenet/pull/441) - **PERFORMANCE:** `Lucene.Net.Tests.Suggest.Spell.TestSpellChecker`: Replaced `ConcurrentBag<T>` with ConcurrentQueue<T> because we need to be sure the underlying implementation guarantees order and the extra call to `Reverse()` was just slowing things down.
+* [#441](https://github.com/apache/lucenenet/pull/441) - `Lucene.Net.TestFramework.Search.ShardSearchingTestBase`: Display the contents of the collection to the console using `Collections.ToString()`.
 * [#441](https://github.com/apache/lucenenet/pull/441) - ` Lucene.Net.Search.SearcherLifetimeManager: Added comment to indicate the reason we use `Lazy<T>` is to make the create operation atomic.
-* [#441](https://github.com/apache/lucenenet/pull/441) - ` Directory.Build.Targets`: Added `FEATURE_DICTIONARY_REMOVE_CONTINUEENUMERATION` so we can support this feature in .NET 5.x + when we add a target.
+* [#441](https://github.com/apache/lucenenet/pull/441) - `Directory.Build.Targets`: Added `FEATURE_DICTIONARY_REMOVE_CONTINUEENUMERATION` so we can support this feature in .NET 5.x + when we add a target.
 * [#442](https://github.com/apache/lucenenet/pull/442) - **PERFORMANCE:** `Lucene.Net.Search.Suggest.Fst.FSTCompletion`: Use `Stack<T>` rather than `List<T>.Reverse()`. Also, removed unnecessary lock in `CheckExistingAndReorder()`, as it is only used in a single thread at a time.
 * [#442](https://github.com/apache/lucenenet/pull/442) - **PERFORMANCE:** `Lucene.Net.Search.Suggest.SortedInputEnumerator`: Removed unnecessary call to `Reverse()` and allocation of `HashSet<T>`
 * [#444](https://github.com/apache/lucenenet/pull/444), [#272](https://github.com/apache/lucenenet/pull/272) - **PERFORMANCE:** `Lucene.Net.Search.FieldCacheImpl`: Reverted locking back to the state of Lucene 4.8.0.

websites/site/release-notes/version-4.8.0-beta00016.md

@@ -35,7 +35,7 @@ It is recommended that all .NET Framework users migrate as soon as possible.
 * [#547](https://github.com/apache/lucenenet/pull/547) - `Lucene.Net.Util.StringHelper.GOOD_FAST_HASH_SEED`: converted from a static field to a property and marked obsolete. Added a new property `GoodFastHashSeed`. Removed `SystemProperties` call to populate the value of the field, since NUnit only allows us to generate a seed per test, and we need a way to inject the seed value for repeatability.
 * [#547](https://github.com/apache/lucenenet/pull/547) - `Lucene.Net.TestFramework`: Added `LuceneSetUpFixtureBuilder` class to load either a subclass or our default instance of `LuceneTestFrameworkInitializer`. Also added `LuceneTestCase.SetUpFixture` to control initialization of `LuceneTestFrameworkInitializer` so it is only called on setup and teardown for the assembly. Added `Initialize()` method to `LuceneTestFrameworkInitializer` that *must be used* when setting factories during testing.
 * [#547](https://github.com/apache/lucenenet/pull/547) - `Lucene.Net.TestFramework.Util.LuceneTestCase`: Deprecated `GetClassType()` method and added `TestType` property
-* [#547](https://github.com/apache/lucenenet/pull/547) - `Lucene.Net.TestFramework.Util.AbstractBeforeAfterRule``: Removed `LuceneTestCase` parameter from `Before()` and `After()` methods.
+* [#547](https://github.com/apache/lucenenet/pull/547) - `Lucene.Net.TestFramework.Util.AbstractBeforeAfterRule`: Removed `LuceneTestCase` parameter from `Before()` and `After()` methods.
 * [#551](https://github.com/apache/lucenenet/pull/551) - Changed constructors of `Lucene.Net.Util.NumberFormat` and `Lucene.Net.QueryParsers.Flexible.Standard.Config.NumberDateFormat` to accept `IFormatProvider` rather than `CultureInfo` and changed `Lucene.Net.Util.NumberFormat.Culture` property to `Lucene.Net.Util.NumberFormat.FormatProvider`.
 * [#554](https://github.com/apache/lucenenet/pull/554) - `Lucene.Net.Misc`: Made `DocFreqComparer` and `TotalTermFreqComparer` into static singletons, only accessible by the `Default` property.
 * [#428](https://github.com/apache/lucenenet/pull/428), [#429](https://github.com/apache/lucenenet/pull/429), [#570](https://github.com/apache/lucenenet/pull/570) - `Lucene.Net.Search.FieldComparer`: Redesigned implementation to use reference types for numerics (from J2N) to avoid boxing.
@@ -86,7 +86,7 @@ It is recommended that all .NET Framework users migrate as soon as possible.
 * [#542](https://github.com/apache/lucenenet/pull/542) - `Lucene.Net.Util.Automation.MinimizationOperations::MinimizeHopcroft()`: Fixed range in `OpenBitSet.Clear()`
 * [#543](https://github.com/apache/lucenenet/pull/543) - `Lucene.Net.Tests.QueryParser.Flexible.Standard.TestQPHelper`: Use `ParseExact()` method to specify the date format, so it works across cultures.
 * [#527](https://github.com/apache/lucenenet/pull/527), [#548](https://github.com/apache/lucenenet/pull/548) - `Lucene.Net.Search.Suggest.Analyzing.BlendedInfixSuggester`: Apply patch from https://issues.apache.org/jira/browse/LUCENE-6093 to fix `ArgumentNullException` if there were discarded trailing characters in the query (Thanks @Maxwellwr)
-* [#550](https://github.com/apache/lucenenet/pull/550) - **SWEEP:** `Use `StringComparer.Ordinal` for `Sort()` methods, where appropriate
+* [#550](https://github.com/apache/lucenenet/pull/550) - **SWEEP:** Use `StringComparer.Ordinal` for `Sort()` methods, where appropriate
 * [#551](https://github.com/apache/lucenenet/pull/551) - `Lucene.Net.QueryParser.Flexible.Standard`: Fixed calendar handling on .NET Core
 * [#552](https://github.com/apache/lucenenet/pull/552) - `Lucene.Net.Suggest.Jaspell.JaspellTernarySearchTree`: Fixed random number generator so it produces random numbers
 * [#553](https://github.com/apache/lucenenet/pull/553), [#609](https://github.com/apache/lucenenet/pull/609) - `Lucene.Net.TestFramework.Util.TestUtil::RandomAnalysisString()`: Fixed `ArgumentOutOfRangeException` when passed a `maxLength` of 0.