Revert async interfaces, unify IReplicationService with Perform/PerformAsync, update ReplicationServlet, Middleware, and TestServer to use single interface

Author: NehanPathan

src/Lucene.Net.Replicator/Http/ReplicationService.cs

@@ -139,6 +139,7 @@ private async Task ExecuteReplicationAsync(
             if (!replicators.TryGetValue(pathElements[SHARD_IDX], out IReplicator replicator))
                 throw ServletException.Create("unrecognized shard ID " + pathElements[SHARD_IDX]);
 
+            // SOLR-8933 Don't close this stream.
             try
             {
                 switch (action)
@@ -175,7 +176,7 @@ private async Task ExecuteReplicationAsync(
             }
             catch (Exception)
             {
-                response.StatusCode = (int)HttpStatusCode.InternalServerError;
+                response.StatusCode = (int)HttpStatusCode.InternalServerError; // propagate the failure
             }
             finally
             {
@@ -208,8 +209,8 @@ public virtual void Perform(IReplicationRequest request, IReplicationResponse re
                     }
                     return Task.CompletedTask;
                 },
-                () => { response.Flush(); return Task.CompletedTask; }
-            ).GetAwaiter().GetResult(); // // keep sync behavior
+                () => { response.Body.Flush(); return Task.CompletedTask; }
+            ).ConfigureAwait(false).GetAwaiter().GetResult(); // keep sync behavior
         }
 
 
@@ -241,7 +242,7 @@ public virtual Task PerformAsync(
                         await token.SerializeAsync(response.Body, cancellationToken);
                     }
                 },
-                () => response.FlushAsync(cancellationToken)
+                () => response.Body.FlushAsync(cancellationToken)
             );
         }
     }

src/Lucene.Net.Replicator/Support/Http/Abstractions/IReplicationResponse.cs

@@ -1,6 +1,4 @@
 using System.IO;
-using System.Threading;
-using System.Threading.Tasks;
 
 namespace Lucene.Net.Replicator.Http.Abstractions
 {
@@ -39,17 +37,5 @@ public interface IReplicationResponse
         /// The response content.
         /// </summary>
         Stream Body { get; }
-
-        /// <summary>
-        /// Flushes the reponse to the underlying response stream.
-        /// </summary>
-        void Flush();
-
-        /// <summary>
-        /// Flushes the response to the underlying response stream asynchronously.
-        /// </summary>
-        /// <param name="cancellationToken">Optional cancellation token.</param>
-        /// <returns>A task representing the asynchronous operation.</returns>
-        Task FlushAsync(CancellationToken cancellationToken = default);
     }
 }

src/Lucene.Net.Tests.Replicator/Http/ReplicationServlet.cs

@@ -2,9 +2,9 @@
 using Lucene.Net.Replicator.AspNetCore;
 using Lucene.Net.Replicator.Http.Abstractions;
 using Microsoft.AspNetCore.Builder;
-using Microsoft.AspNetCore.Routing;
 using Microsoft.AspNetCore.Hosting;
 using Microsoft.AspNetCore.Http;
+using Microsoft.AspNetCore.Routing;
 using System;
 using System.Threading.Tasks;
 

src/Lucene.Net.Tests.Replicator/Support/Net/HttpListenerReplicationResponse.cs

@@ -40,10 +40,5 @@ public int StatusCode
         }
 
         public Stream Body => _response.OutputStream;
-
-        public void Flush() => _response.OutputStream.Flush();
-
-        public Task FlushAsync(CancellationToken cancellationToken = default) =>
-            _response.OutputStream.FlushAsync(cancellationToken);
     }
 }

src/Lucene.Net.Tests.Replicator/Support/Net/TestServer.cs

@@ -107,7 +107,7 @@ private async Task ListenLoopAsync(CancellationToken token)
                         }
                         finally
                         {
-                            await response.FlushAsync(token);
+                            await response.Body.FlushAsync(token);
                             context.Response.Close();
                         }
                     }, token);

src/dotnet/Lucene.Net.Replicator.AspNetCore/AspNetCoreReplicationResponse.cs

@@ -1,8 +1,6 @@
 using Lucene.Net.Replicator.Http.Abstractions;
 using Microsoft.AspNetCore.Http;
 using System.IO;
-using System.Threading;
-using System.Threading.Tasks;
 
 namespace Lucene.Net.Replicator.AspNetCore
 {
@@ -59,29 +57,5 @@ public int StatusCode
         /// This simply returns the <see cref="HttpResponse.Body"/>.
         /// </remarks>
         public Stream Body => response.Body;
-
-        /// <summary>
-        /// Flushes the reponse to the underlying response stream.
-        /// </summary>
-        /// <remarks>
-        /// This simply calls <see cref="Stream.Flush"/> on the <see cref="HttpResponse.Body"/>.
-        /// </remarks>
-        public void Flush()
-        {
-            response.Body.Flush();
-        }
-
-        /// <summary>
-        /// Flushes the response to the underlying response stream asynchronously.
-        /// </summary>
-        /// <param name="cancellationToken">Optional cancellation token.</param>
-        /// <returns>A task representing the asynchronous operation.</returns>
-        /// <remarks>
-        /// This simply calls <see cref="Stream.FlushAsync(CancellationToken)"/> on the <see cref="HttpResponse.Body"/>.
-        /// </remarks>
-        public async Task FlushAsync(CancellationToken cancellationToken = default)
-        {
-            await response.Body.FlushAsync(cancellationToken);
-        }
     }
 }