Commit 9db3846
Add breadcrumbs for assertEventQueueAfterClose and closeInternal removals, #1284
Upstream 2cfcdcc rewrote close(boolean) to delegate to shutdown(boolean)
but kept assertEventQueueAfterClose() and closeInternal(boolean, boolean)
as private dead code. The original #1284 port (7ec8790) dropped both,
which matches trunk LUCENE-4246's eventual cleanup (8559eaf, Lucene 5.0)
but diverges from the conservative branch_4x state at 2cfcdcc.
Adds two LUCENENET breadcrumbs around ShouldClose() so a future porter
diffing against 2cfcdcc can find the removal rationale at the position
where each method used to live:
- Full note before ShouldClose() covering both, since
assertEventQueueAfterClose() sat there in upstream.
- One-liner after ShouldClose() pointing back to the full note, since
closeInternal() sat immediately after.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>1 parent 08d82e8 commit 9db3846
1 file changed
Lines changed: 11 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1227 | 1227 | | |
1228 | 1228 | | |
1229 | 1229 | | |
| 1230 | + | |
| 1231 | + | |
| 1232 | + | |
| 1233 | + | |
| 1234 | + | |
| 1235 | + | |
| 1236 | + | |
| 1237 | + | |
1230 | 1238 | | |
1231 | 1239 | | |
1232 | 1240 | | |
| |||
1266 | 1274 | | |
1267 | 1275 | | |
1268 | 1276 | | |
| 1277 | + | |
| 1278 | + | |
| 1279 | + | |
1269 | 1280 | | |
1270 | 1281 | | |
1271 | 1282 | | |
| |||
0 commit comments