Revert port of 9d10d6f92cc - moved to batch 4 PR

Author: paulirwin

src/Lucene.Net.Tests/Util/TestOfflineSorter.cs

@@ -311,27 +311,5 @@ public virtual void TestRamBuffer()
             Assert.Throws<ArgumentOutOfRangeException>(() => OfflineSorter.BufferSize.Megabytes(0), "min mb is 0.5");
             Assert.Throws<ArgumentOutOfRangeException>(() => OfflineSorter.BufferSize.Megabytes(-1), "min mb is 0.5");
         }
-
-        [Test, LuceneNetSpecific]
-        public void TestWrite_ArgumentValidation()
-        {
-            FileInfo file = new FileInfo(Path.Combine(tempDir.FullName, "testWrite_ArgumentValidation"));
-            using var stream = new FileStream(file.FullName, FileMode.CreateNew, FileAccess.ReadWrite, FileShare.Read,
-                bufferSize: OfflineSorter.DEFAULT_FILESTREAM_BUFFER_SIZE, FileOptions.DeleteOnClose);
-            using OfflineSorter.ByteSequencesWriter w = new OfflineSorter.ByteSequencesWriter(stream, leaveOpen: true);
-
-            // ReSharper disable AccessToDisposedClosure
-            Assert.Throws<ArgumentNullException>(() => w.Write(((byte[])null)!));
-            Assert.Throws<ArgumentNullException>(() => w.Write(((BytesRef)null)!));
-            Assert.Throws<ArgumentOutOfRangeException>(() => w.Write([], -1, 1), "datum");
-            Assert.Throws<ArgumentOutOfRangeException>(() => w.Write([], 0, -1), "datum");
-            Assert.Throws<ArgumentException>(() => w.Write([], 0, 1), "datum");
-
-            // validate that len is less than or equal to short.MaxValue
-            var bigArray = new byte[short.MaxValue + 2]; // give extra space so that off <= bytes.Length - len
-            Assert.Throws<ArgumentOutOfRangeException>(() => w.Write(bigArray, 0, short.MaxValue + 1), "datum");
-            Assert.DoesNotThrow(() => w.Write(bigArray, 0, short.MaxValue));
-            // ReSharper restore AccessToDisposedClosure
-        }
     }
 }

src/Lucene.Net/Util/OfflineSorter.cs

@@ -670,7 +670,7 @@ public virtual void Write(byte[] bytes)
             /// by the bytes.
             /// </summary>
             /// <exception cref="ArgumentNullException"><paramref name="bytes"/> is <c>null</c>.</exception>
-            /// <exception cref="ArgumentOutOfRangeException"><paramref name="off"/> or <paramref name="len"/> is less than 0, or <paramref name="len"/> is greater than <see cref="short.MaxValue"/>.</exception>
+            /// <exception cref="ArgumentOutOfRangeException"><paramref name="off"/> or <paramref name="len"/> is less than 0.</exception>
             /// <exception cref="ArgumentException"><paramref name="off"/> and <paramref name="len"/> refer to a position outside of the array.</exception>
             public virtual void Write(byte[] bytes, int off, int len)
             {
@@ -683,10 +683,6 @@ public virtual void Write(byte[] bytes, int off, int len)
                 if (off > bytes.Length - len) // Checks for int overflow
                     throw new ArgumentException("Index and length must refer to a location within the array.");
 
-                // Lucene 4.8.1 commit 9d10d6f92cc (no JIRA number given)
-                if (len > short.MaxValue)
-                    throw new ArgumentOutOfRangeException(nameof(len), $"len must be <= {short.MaxValue}; got {len}");
-
                 os.Write((short)len);
                 os.Write(bytes, off, len);
             }