PR feedback

Author: paulirwin

src/Lucene.Net/Index/BinaryDocValuesWriter.cs

@@ -1,3 +1,4 @@
+using Lucene.Net.Diagnostics;
 using System;
 using System.Collections.Generic;
 
@@ -147,7 +148,8 @@ private IEnumerable<BytesRef> GetBytesIterator(int maxDocParam)
                 BytesRef v = null;
                 if (upto < size)
                 {
-                    lengthsEnumerator.MoveNext();
+                    bool moved = lengthsEnumerator.MoveNext();
+                    if (Debugging.AssertsEnabled) Debugging.Assert(moved);
                     int length = (int)lengthsEnumerator.Current;
                     value.Grow(length);
                     value.Length = length;

src/Lucene.Net/Index/NumericDocValuesWriter.cs

@@ -1,3 +1,4 @@
+using Lucene.Net.Diagnostics;
 using Lucene.Net.Util.Packed;
 using System;
 using System.Collections.Generic;
@@ -111,7 +112,8 @@ public override void Flush(SegmentWriteState state, DocValuesConsumer dvConsumer
                 long? value;
                 if (upto < size)
                 {
-                    enumerator.MoveNext();
+                    bool moved = enumerator.MoveNext();
+                    if (Debugging.AssertsEnabled) Debugging.Assert(moved);
                     var v = enumerator.Current;
                     if (docsWithField is null || docsWithField.Get(upto))
                     {

src/Lucene.Net/Index/SortedDocValuesWriter.cs

@@ -149,7 +149,8 @@ private IEnumerable<BytesRef> GetBytesRefEnumerable(int valueCount, int[] sorted
 
             for (int i = 0; i < maxDoc; ++i)
             {
-                enumerator.MoveNext();
+                bool moved = enumerator.MoveNext();
+                if (Debugging.AssertsEnabled) Debugging.Assert(moved);
                 int ord = (int)enumerator.Current;
                 yield return ord == -1 ? ord : ordMap[ord];
             }

src/Lucene.Net/Index/SortedSetDocValuesWriter.cs

@@ -208,7 +208,8 @@ private IEnumerable<BytesRef> GetValuesEnumerable(int valueCount, int[] sortedVa
 
             for (int docUpto = 0; docUpto < maxDoc; ++docUpto)
             {
-                enumerator.MoveNext();
+                bool moved = enumerator.MoveNext();
+                if (Debugging.AssertsEnabled) Debugging.Assert(moved);
                 yield return enumerator.Current;
             }
         }
@@ -227,11 +228,13 @@ private IEnumerable<BytesRef> GetValuesEnumerable(int valueCount, int[] sortedVa
                 {
                     // refill next doc, and sort remapped ords within the doc.
                     currentUpTo = 0;
-                    counts.MoveNext();
+                    bool countsMoved = counts.MoveNext();
+                    if (Debugging.AssertsEnabled) Debugging.Assert(countsMoved);
                     currentLength = (int)counts.Current;
                     for (int j = 0; j < currentLength; j++)
                     {
-                        enumerator.MoveNext();
+                        bool moved = enumerator.MoveNext();
+                        if (Debugging.AssertsEnabled) Debugging.Assert(moved);
                         cd[j] = ordMap[(int)enumerator.Current];
                     }
                     Array.Sort(cd, 0, currentLength);