Skip to content

Commit d860529

Browse files
committed
[SUREFIRE-2240] Don't manage JUnit5 artifact versions
This allows to more easily overwrite the version via plugin dependencies
1 parent 2fed802 commit d860529

File tree

2 files changed

+10
-8
lines changed

2 files changed

+10
-8
lines changed

pom.xml

-8
Original file line numberDiff line numberDiff line change
@@ -308,14 +308,6 @@
308308
<version>${jacocoVersion}</version>
309309
<classifier>runtime</classifier>
310310
</dependency>
311-
<dependency>
312-
<!-- Do not upgrade, leads to test failures, needs analysis -->
313-
<groupId>org.junit</groupId>
314-
<artifactId>junit-bom</artifactId>
315-
<version>5.9.3</version>
316-
<type>pom</type>
317-
<scope>import</scope>
318-
</dependency>
319311
</dependencies>
320312
</dependencyManagement>
321313
<dependencies>

surefire-providers/surefire-junit-platform/pom.xml

+10
Original file line numberDiff line numberDiff line change
@@ -80,6 +80,13 @@
8080
<tag>surefire-3.0.0-M8</tag>
8181
</scm>
8282

83+
<properties>
84+
<!-- common version suffix by platform and other junit5 artifacts, compare with https://github.com/junit-team/junit5/blob/main/gradle.properties -->
85+
<junit5VersionSuffix>9.3</junit5VersionSuffix>
86+
<junit5Version>5.${junit5VersionSuffix}</junit5Version>
87+
<junitPlatformVersion>1.${junit5VersionSuffix}</junitPlatformVersion>
88+
</properties>
89+
8390
<dependencies>
8491
<dependency>
8592
<groupId>org.apache.maven.surefire</groupId>
@@ -89,15 +96,18 @@
8996
<dependency>
9097
<groupId>org.junit.platform</groupId>
9198
<artifactId>junit-platform-launcher</artifactId>
99+
<version>${junitPlatformVersion}</version>
92100
</dependency>
93101
<dependency>
94102
<groupId>org.junit.jupiter</groupId>
95103
<artifactId>junit-jupiter-engine</artifactId>
104+
<version>${junit5Version}</version>
96105
<scope>test</scope>
97106
</dependency>
98107
<dependency>
99108
<groupId>org.junit.jupiter</groupId>
100109
<artifactId>junit-jupiter-params</artifactId>
110+
<version>${junit5Version}</version>
101111
<scope>test</scope>
102112
</dependency>
103113
<dependency>

0 commit comments

Comments
 (0)